From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66279C47404 for ; Mon, 7 Oct 2019 18:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FEA320684 for ; Mon, 7 Oct 2019 18:36:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cgP9FKCa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728459AbfJGSg4 (ORCPT ); Mon, 7 Oct 2019 14:36:56 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:40883 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728081AbfJGSgz (ORCPT ); Mon, 7 Oct 2019 14:36:55 -0400 Received: by mail-qt1-f193.google.com with SMTP id m61so9589330qte.7; Mon, 07 Oct 2019 11:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fXL8J/OQJmreiyptvpgxHievcJo6KOM1a1ady8Gq0qE=; b=cgP9FKCa+Rmg1fTWx4Msi4HhEyQYM8Leky4PtPKPdo9NVLQNF7g+tQice2NdsF1wle 7dMOsp5hA0jBv4ORML7x3lEzYii1kVHIj43FMVWOP7GiA83bcRuJCWAQAaAD9VMiPrvr Q4TlQdpN5rBvYAGZzCI8xZtC0U28TWXpzW0r38zOei3eZDv+iAhBrWsDAkVKaAODQrx0 dm5G/+su7Y2HRKWxoFPFq9b1JFxMLf40knrHIHJjUdysI2s9YJSHzeuBh8+A3P33RZ12 oMjBE6ZB562H0IZx8QoH5hbAdYn4ah4LsJ0gVqNjUzOWIqn3nyvY7+KSV3YUZKDgNKDK v1ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fXL8J/OQJmreiyptvpgxHievcJo6KOM1a1ady8Gq0qE=; b=BjKfLIbtxA9rSmyNR7lGC9QPxwgB+HxZ1ZydLRFeSAXN/DBL5XsJgdv23IjPd6Aa42 lKcmFeEsbOJcwIauEDzDKn12k3EN/YYGYOQpJKiM8SHn4279Sj5wy20lvNAgRybw61Lf oYFig1eLb6oDnwrLc5U4RLWKcVsxotHtRsrd1wBvw7YaXHztL/N+H0qemHXjvN0/PhFG qRjpPbZAsYHx5Y68ysz6l0v9guCBe/ApO/3NQmsGRdAI7fsltmF6figwW0QCfyBzUtsL VKC6cSVplHPZzWe056WDhVBKkEqJ+9IDBqZpayQSSwFa7EIlHkHQIwOu3HjrG6rpRFfA OLHQ== X-Gm-Message-State: APjAAAVYR9Ld45rNtvDHSzNB5YYFGH6yR1Mdl/VPwC3UgMMI3AuEHVO7 EgmecaPi/QVEYqIQ/iZ9shykGNACM5D2l9xh5ZF2QnMJ X-Google-Smtp-Source: APXvYqy70SsUjoYiUVpnHDEy2rjlLPhOO4kwSxJXoIqnTOLmTqH8ik5f+3V4sa/1uDzyb0En521XO1kijR4HgNI3kqI= X-Received: by 2002:ac8:2aaf:: with SMTP id b44mr32435987qta.359.1570473414763; Mon, 07 Oct 2019 11:36:54 -0700 (PDT) MIME-Version: 1.0 References: <20191006222046.GA18027@roeck-us.net> <5f06c138-d59a-d811-c886-9e73ce51924c@roeck-us.net> <20191007012437.GK26530@ZenIV.linux.org.uk> <20191007025046.GL26530@ZenIV.linux.org.uk> In-Reply-To: From: Tony Luck Date: Mon, 7 Oct 2019 11:36:43 -0700 Message-ID: Subject: Re: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user() To: Linus Torvalds Cc: Al Viro , Guenter Roeck , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 7, 2019 at 11:28 AM Linus Torvalds wrote: > > On Sun, Oct 6, 2019 at 8:11 PM Linus Torvalds > wrote: > > > > > > > > The last two should just do user_access_begin()/user_access_end() > > > instead of access_ok(). __copy_to_user_inatomic() has very few callers as well: > > > > Yeah, good points. > > Looking at it some more this morning, I think it's actually pretty painful. Late to this party ,,, but my ia64 console today is full of: irqbalance(5244): unaligned access to 0x2000000800042f9b, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fbb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fdb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042ffb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x200000080004301b, ip=0xa0000001002fef90 ia64_handle_unaligned: 95 callbacks suppressed irqbalance(5244): unaligned access to 0x2000000800042f9b, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fbb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042fdb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x2000000800042ffb, ip=0xa0000001002fef90 irqbalance(5244): unaligned access to 0x200000080004301b, ip=0xa0000001002fef90 ia64_handle_unaligned: 95 callbacks suppressed Those ip's point into filldir64() -Tony