linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Marcel Holtmann <marcel@holtmann.org>
Cc: Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Rajat Jain <rajatja@google.com>, Heiko Stuebner <heiko@sntech.de>,
	Johan Hedberg <johan.hedberg@gmail.com>
Subject: Re: [PATCH] Bluetooth: btusb: request wake pin with NOAUTOEN
Date: Mon, 1 Apr 2019 11:07:11 -0700	[thread overview]
Message-ID: <CA+ASDXM9ciP6uxxA1ewhkK-Xh-DSKGzedw1UJH59sC7JsOtHoQ@mail.gmail.com> (raw)
In-Reply-To: <CA+ASDXNYZhOeef_7nhZf1GYhdxubE7v+ustG8zDigGHVOYWRFg@mail.gmail.com>

+ akpm, in case he can help out

Another week, another buggy 5.1 RC.

On Tue, Mar 26, 2019 at 11:48 AM Brian Norris <briannorris@chromium.org> wrote:
>
> On Thu, Feb 21, 2019 at 4:30 PM Brian Norris <briannorris@chromium.org> wrote:
> >
> > Badly-designed systems might have (for example) active-high wake pins
> > that default to high (e.g., because of external pull ups) until they
> > have an active firmware which starts driving it low. This can cause an
> > interrupt storm in the time between request_irq() and disable_irq().
> >
> > We don't support shared interrupts here, so let's just pre-configure the
> > interrupt to avoid auto-enabling it.
> >
> > Fixes: fd913ef7ce61 ("Bluetooth: btusb: Add out-of-band wakeup support")
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> Ping! v5.1 is enabling wake support on Scarlet, and without this
> patch, that causes interrupt storms at boot. Please apply this patch
> for v5.1-rc!
>
> See also:
> https://lkml.kernel.org/lkml/CA+ASDXMePkQDRfaSwNGnRYyGdsuvfUCXBtDK79o2mP=1hdNQUA@mail.gmail.com

Ping x 2!

Marcel merged my other series first, which enabled this feature,
without applying the bugfix (which was sent first). So right now, my
RK3399/Scarlet board is in very bad shape. Can somebody please merge
this bugfix for 5.1? If not, I'll probably just send Linus a pull
request myself.

Original patch link, in case this helps someone:

http://lkml.kernel.org/lkml/20190222003051.127006-1-briannorris@chromium.org
https://lore.kernel.org/patchwork/patch/1044896/

Thanks,
Brian

      reply	other threads:[~2019-04-01 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  0:30 Brian Norris
2019-02-22 18:35 ` Matthias Kaehlcke
2019-03-26 18:48 ` Brian Norris
2019-04-01 18:07   ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+ASDXM9ciP6uxxA1ewhkK-Xh-DSKGzedw1UJH59sC7JsOtHoQ@mail.gmail.com \
    --to=briannorris@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=heiko@sntech.de \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mka@chromium.org \
    --cc=rajatja@google.com \
    --subject='Re: [PATCH] Bluetooth: btusb: request wake pin with NOAUTOEN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).