linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Tsuchiya Yuto <kitakar@gmail.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
	Ganapathi Bhat <ganapathi.bhat@nxp.com>,
	Xinming Hu <huxinming820@gmail.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Maximilian Luz <luzmaximilian@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	verdre@v0yd.nl
Subject: Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter
Date: Wed, 28 Oct 2020 15:04:55 -0700	[thread overview]
Message-ID: <CA+ASDXMXoyOr9oHBjtXZ1w9XxDggv+=XS4nwn0qKWCHQ3kybdw@mail.gmail.com> (raw)
In-Reply-To: <20201028142433.18501-3-kitakar@gmail.com>

On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto <kitakar@gmail.com> wrote:
>
> To make the ps_mode (power_save) control easier, this commit adds a new
> module parameter allow_ps_mode and set it false (disallowed) by default.

This sounds like a bad idea, as it breaks all the existing users who
expect this feature to be allowed. Seems like you should flip the
defaults. Without some better justification, NACK.

Also, I can't find the other 2 patches in this alleged series. Maybe
they're still making it through the mailing lists and archives.

Brian

> When this parameter is set to false, changing the power_save mode will
> be disallowed like the following:
>
>     $ sudo iw dev mlan0 set power_save on
>     command failed: Operation not permitted (-1)
>
> Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>

  reply	other threads:[~2020-10-28 22:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 14:24 [PATCH 0/3] mwifiex: disable ps_mode by default for stability Tsuchiya Yuto
2020-10-28 14:24 ` [PATCH 1/3] mwifiex: disable ps_mode explicitly by default instead Tsuchiya Yuto
2020-10-29 18:25   ` Brian Norris
2020-10-29 18:36     ` Andy Shevchenko
2020-10-29 18:56       ` Brian Norris
2020-10-30  8:04     ` Tsuchiya Yuto
2020-11-20 21:04       ` Brian Norris
2020-11-26 19:44         ` Tsuchiya Yuto
2020-10-28 14:24 ` [PATCH 2/3] mwifiex: add allow_ps_mode module parameter Tsuchiya Yuto
2020-10-28 22:04   ` Brian Norris [this message]
2020-10-29 17:04     ` Willem de Bruijn
2020-10-30  8:02       ` Tsuchiya Yuto
2020-10-30  7:58     ` Tsuchiya Yuto
2020-10-30 11:02       ` Andy Shevchenko
2020-11-02  9:18         ` Tsuchiya Yuto
2020-10-28 14:24 ` [PATCH 3/3] mwifiex: print message when changing ps_mode Tsuchiya Yuto
     [not found] ` <20201028152115.GT4077@smile.fi.intel.com>
2020-10-30  8:26   ` [PATCH 0/3] mwifiex: disable ps_mode by default for stability Tsuchiya Yuto
2020-12-20 21:43 ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ASDXMXoyOr9oHBjtXZ1w9XxDggv+=XS4nwn0qKWCHQ3kybdw@mail.gmail.com' \
    --to=briannorris@chromium.org \
    --cc=amitkarwar@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=davem@davemloft.net \
    --cc=ganapathi.bhat@nxp.com \
    --cc=huxinming820@gmail.com \
    --cc=kitakar@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=verdre@v0yd.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).