From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB00BC433DF for ; Wed, 8 Jul 2020 23:03:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93CCB206DF for ; Wed, 8 Jul 2020 23:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RNAYnBEg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726169AbgGHXDq (ORCPT ); Wed, 8 Jul 2020 19:03:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgGHXDq (ORCPT ); Wed, 8 Jul 2020 19:03:46 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 031D5C061A0B for ; Wed, 8 Jul 2020 16:03:45 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id a32so297944qtb.5 for ; Wed, 08 Jul 2020 16:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=To0+Smg43e/9CvTBABgED+cYpEQSStMGVMvi2i5fPzg=; b=RNAYnBEgE2TiqdyUeojImy8gOwbVIOFQQSEjYG9KHdt061+dFG2b6jIUUBiUdQPmWP deilgIVor23VxDCpWJSMXIwqiBgoH2437YnkMzPREaSjNBTwA6LUpqctj7unzQTUdblH y4ikK2xUtF+NbXQGkN8KYqXc1LKB/rvSP17sA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=To0+Smg43e/9CvTBABgED+cYpEQSStMGVMvi2i5fPzg=; b=ddG8tBN5gtr5lA3wtp4EzNRoR6T4aXFz1NweuM5Vhb36p48m8mBpwb0b+WznJxoi7V nHRYHHBhHLDko4gTmjHg+3KGhdVsU6ncYnVZyIqS1SvtAQLdg5VfBq/iInE8di7QKYAR nkhTLS//2omAQiTJHxzQGxuSJZWuvlFODheBVj7gsZ1oCZ8ID2gRA7UVb5/bvQuEvsU0 BXqUqz1D73T89aFIsIa5weMRmSaqJPz4J0E0HGPiGBm4fmuA13d3YDxf/6I7dEQ4R9Qm GUYl072l5lxDZjzeiZhu0G6C9FYoKV9GlWjsIipsR2k7kK1bonwPHmsrCeSuRWPYI8IT g6lA== X-Gm-Message-State: AOAM532RlX4A99fWIeAToK8CIYf0FNvCAJcz/kCAiOKPXVpJjW7p3V8r Z3Vbe3RMEnRnFpURHmR/2iT/1mltYf8= X-Google-Smtp-Source: ABdhPJw7ePw1M2VQhg9mOqsZ7IsbybY/LQiHO9lISVsq8r2oWpr5+FzbHSG+CDeV6j3GZCanCf/B7A== X-Received: by 2002:ac8:18a5:: with SMTP id s34mr60761723qtj.210.1594249424459; Wed, 08 Jul 2020 16:03:44 -0700 (PDT) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com. [209.85.222.171]) by smtp.gmail.com with ESMTPSA id s71sm1489994qke.0.2020.07.08.16.03.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 16:03:42 -0700 (PDT) Received: by mail-qk1-f171.google.com with SMTP id c139so43070qkg.12 for ; Wed, 08 Jul 2020 16:03:42 -0700 (PDT) X-Received: by 2002:a37:b6c6:: with SMTP id g189mr44795113qkf.206.1594249421577; Wed, 08 Jul 2020 16:03:41 -0700 (PDT) MIME-Version: 1.0 References: <20200707101712.1.I4d2f85ffa06f38532631e864a3125691ef5ffe06@changeid> In-Reply-To: <20200707101712.1.I4d2f85ffa06f38532631e864a3125691ef5ffe06@changeid> From: Brian Norris Date: Wed, 8 Jul 2020 16:03:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them To: Douglas Anderson Cc: Kalle Valo , ath10k , saiprakash.ranjan@codeaurora.org, linux-arm-msm , linux-wireless , Rakesh Pillai , Abhishek Kumar , "David S. Miller" , Jakub Kicinski , Linux Kernel , "" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 7, 2020 at 10:18 AM Douglas Anderson wrote: > diff --git a/drivers/net/wireless/ath/ath10k/ce.h b/drivers/net/wireless/ath/ath10k/ce.h > index a440aaf74aa4..666ce384a1d8 100644 > --- a/drivers/net/wireless/ath/ath10k/ce.h > +++ b/drivers/net/wireless/ath/ath10k/ce.h ... > @@ -376,12 +377,9 @@ static inline u32 ath10k_ce_interrupt_summary(struct ath10k *ar) > { > struct ath10k_ce *ce = ath10k_ce_priv(ar); > > - if (!ar->hw_params.per_ce_irq) If I'm reading correctly, you're removing the only remaining use of 'per_ce_irq'. Should we kill the field entirely? Or perhaps we should leave some kind of WARN_ON() (BUG_ON()?) if this function is called erroneously with per_ce_irq==true? But I suppose this driver is full of landmines if the CE API is used incorrectly. > - return CE_WRAPPER_INTERRUPT_SUMMARY_HOST_MSI_GET( > - ce->bus_ops->read32((ar), CE_WRAPPER_BASE_ADDRESS + > - CE_WRAPPER_INTERRUPT_SUMMARY_ADDRESS)); > - else > - return ath10k_ce_gen_interrupt_summary(ar); > + return CE_WRAPPER_INTERRUPT_SUMMARY_HOST_MSI_GET( > + ce->bus_ops->read32((ar), CE_WRAPPER_BASE_ADDRESS + > + CE_WRAPPER_INTERRUPT_SUMMARY_ADDRESS)); > } > > /* Host software's Copy Engine configuration. */ > diff --git a/drivers/net/wireless/ath/ath10k/snoc.h b/drivers/net/wireless/ath/ath10k/snoc.h > index a3dd06f6ac62..5095d1893681 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.h > +++ b/drivers/net/wireless/ath/ath10k/snoc.h > @@ -78,6 +78,7 @@ struct ath10k_snoc { > unsigned long flags; > bool xo_cal_supported; > u32 xo_cal_data; > + DECLARE_BITMAP(pending_ce_irqs, CE_COUNT_MAX); Do you need to clear this map if the interface goes down or if there's a firmware crash? Right now, I don't think there's a guarantee that we'll run through a NAPI poll in those cases, which is the only place you clear the map, and if the hardware/firmware has been reset, the state map is probably not valid. Otherwise, looks OK to me: Reviewed-by: Brian Norris