From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6E0C4167B for ; Thu, 10 Dec 2020 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FD4623C44 for ; Thu, 10 Dec 2020 18:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404146AbgLJSPd (ORCPT ); Thu, 10 Dec 2020 13:15:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403968AbgLJSOl (ORCPT ); Thu, 10 Dec 2020 13:14:41 -0500 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE32C0613CF for ; Thu, 10 Dec 2020 10:14:01 -0800 (PST) Received: by mail-ot1-x343.google.com with SMTP id h18so5751280otq.12 for ; Thu, 10 Dec 2020 10:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YYa3QwHjcr9KvgYh2cWR2ObRxXNVCxcMJKU5e9f8sD8=; b=numcK5p0fC6i0qHz1HrhREaD7+WeZR49j5Ld8oazdIWYJjGMor8RpCWz6WEkvH0SS+ UlJYu/zIOO+mGE3A2M3CsowAbX/TuO3db5uEQkhqW1AIzEQlhcn0NLDHs0f1QYGqjWO6 s4pU9wOxBze02RZqscoOgYQ1YRCTvJMyALiqw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YYa3QwHjcr9KvgYh2cWR2ObRxXNVCxcMJKU5e9f8sD8=; b=TRCm3jQQUARG/Ptj2k1uycuD4kzhUKXLu1xIHoDZ5e3W4iPeaHTmX+tfKo62YXPx0a 0AIKJtanL9xfv/X/2W+jBrx5F8m9PaJGoxd0XofvJTArv/4RZvEewr58rB1xNIocJWR6 HoOggPzWa7HNIAamsq2DK+kW/ORhhtp5rbHKEyftTo5rovDpbY8CAHktplRwdIxT0A/5 aQzd5WCvM6lfdVfJ3yG5k0SvxTtyr+kRKFbj88OXKjyFyuPEz0R2McGQiszA5+xej0FY 6isKsv2S+58FXnlGxEzuXas4T2EfKJlaycsg8bdvMBkvmqvH5TFnJ40/wjxVTFSPGXb9 +6Pg== X-Gm-Message-State: AOAM532tyc9NM2x+5Bd5yuEcb50bpJMkQOb1uzgVXzLgT+tFdmMEbqeB H6tFwOPbFMxHwH7SfHGcz7DXrB9VLQdhVQ== X-Google-Smtp-Source: ABdhPJzUlkUG/BITLXb5RRxyxqOPgoOt73F/PAgXXw8es1xb68twKcc8cvL1XCKIGzp8SKt1KLyfmA== X-Received: by 2002:a9d:12c:: with SMTP id 41mr6766588otu.77.1607624040467; Thu, 10 Dec 2020 10:14:00 -0800 (PST) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com. [209.85.167.177]) by smtp.gmail.com with ESMTPSA id e81sm1158596oia.30.2020.12.10.10.13.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Dec 2020 10:13:58 -0800 (PST) Received: by mail-oi1-f177.google.com with SMTP id l200so6718099oig.9 for ; Thu, 10 Dec 2020 10:13:58 -0800 (PST) X-Received: by 2002:aca:6502:: with SMTP id m2mr6058702oim.105.1607624038142; Thu, 10 Dec 2020 10:13:58 -0800 (PST) MIME-Version: 1.0 References: <1607612975-5756-1-git-send-email-pillair@codeaurora.org> In-Reply-To: <1607612975-5756-1-git-send-email-pillair@codeaurora.org> From: Brian Norris Date: Thu, 10 Dec 2020 10:13:46 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ath10k: Remove voltage regulator votes during wifi disable To: Rakesh Pillai Cc: ath10k , linux-wireless , Linux Kernel , Doug Anderson , kuabhs@chromium.org, Youghandhar Chintala Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 7:09 AM Rakesh Pillai wrote: > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -1045,14 +1085,18 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar, > ret = ath10k_snoc_init_pipes(ar); > if (ret) { > ath10k_err(ar, "failed to initialize CE: %d\n", ret); > - goto err_wlan_enable; > + goto err_free_rri; > } > > return 0; > > -err_wlan_enable: > +err_free_rri: > + ath10k_ce_free_rri(ar); This change in the error path seems to be an unrelated (but correct) fix. It deserves its own patch, I think. Brian > ath10k_snoc_wlan_disable(ar); > > +err_hw_power_off: > + ath10k_hw_power_off(ar); > + > return ret; > } >