linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: shuah <shuah@kernel.org>
Cc: David Valleau <valleau@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <alexander.levin@microsoft.com>
Subject: Re: [PATCH] tools: usb: usbip: adding support for older kernel versions
Date: Tue, 26 Mar 2019 18:16:15 -0700	[thread overview]
Message-ID: <CA+ASDXNMBTwY1ianfXrS1mGOi7TzekOwTULxpCaCqM6vZYbZ6g@mail.gmail.com> (raw)
In-Reply-To: <01ee061c-bbf5-12f2-8e0e-eda3f9132ad0@kernel.org>

On Mon, Mar 25, 2019 at 6:59 PM shuah <shuah@kernel.org> wrote:
> 1. I plan to fix the tool to make it run on older kernels (pre-USB 3.0).

Great, thanks! We will probably do something downstream anyway, based
off the work David has done. But it would be great if upstream
supported this too.

> 2. I don't plan to support old tool running on new kernels. It doesn't
> make sense considering the security fixes. You can use the latest on
> older kernels (pre-USB 3.0).

Agreed for sufficiently-old tools. (Say, for instance, before this
year, where it seems we now agree that the interface shouldn't change
unnecessarily.) But eventually, this is an essential part of any
mature interface: that today's tools don't break on tomorrow's kernel.
(And yes, Greg noted that old things must die eventually, esp. for
such low-level stuff, so that might not be true for sufficiently long
values of "tomorrow." But it shouldn't be taken lightly.)

I think we already more or less agreed on that, but in case we didn't,
I want to make the disagreement clear.

> 3. I am going to assume you are *using* the latest stable kernels that
> have the security fixes.

That's a reasonable assumption. It's not necessarily a true one (prior
to 4.4, where we started taking that seriously), but where it's not
true, it's our problem not yours.

Thanks,
Brian

  reply	other threads:[~2019-03-27  1:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 21:47 [PATCH] tools: usb: usbip: adding support for older kernel versions David Valleau
2019-03-16 23:39 ` shuah
2019-03-18 18:23   ` Brian Norris
2019-03-25 15:51     ` shuah
2019-03-25 17:56       ` Brian Norris
2019-03-25 22:07         ` shuah
2019-03-25 23:02           ` Brian Norris
2019-03-26  0:04             ` shuah
2019-03-26  1:29               ` Brian Norris
2019-03-26  1:59                 ` shuah
2019-03-27  1:16                   ` Brian Norris [this message]
2019-03-26  0:13             ` Greg Kroah-Hartman
2019-03-26  0:49               ` Brian Norris
2019-03-26  0:55                 ` Greg Kroah-Hartman
2019-03-26  1:28                   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+ASDXNMBTwY1ianfXrS1mGOi7TzekOwTULxpCaCqM6vZYbZ6g@mail.gmail.com \
    --to=briannorris@chromium.org \
    --cc=alexander.levin@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    --cc=valleau@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).