From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D2BC55179 for ; Thu, 29 Oct 2020 18:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72E7D20825 for ; Thu, 29 Oct 2020 18:57:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="B6yphniA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725805AbgJ2S5Q (ORCPT ); Thu, 29 Oct 2020 14:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbgJ2S5Q (ORCPT ); Thu, 29 Oct 2020 14:57:16 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8A9FC0613D3 for ; Thu, 29 Oct 2020 11:57:15 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id y16so4313921ljk.1 for ; Thu, 29 Oct 2020 11:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XcpjY/kPuA4EUV38Vs/YpJREclicBfcPi/8OJvF6Zp0=; b=B6yphniAqXI/GkxR8wlQNDbHRgM5TshKPwVtKrK8jOos7zF9eY3gzOl2cccs+yWfDX AjJg7HxGwBrveb2dUENJQqABKBREdFP7zrT9Bgrqunm0xBWw65IuEcQ0CgFpmW2Rz8hN 7fCmzEcale9NOmacj68mTfmCccOjFRMQzUMwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XcpjY/kPuA4EUV38Vs/YpJREclicBfcPi/8OJvF6Zp0=; b=fU397jCi7pqbT//2mMbexerXMH9fq0RXTI5hJgvJM84+MStTlRmwtx/sjRFBAN942j cAcAQfOmr4q49s6a11PXT37M5OoA6Q3r3OF/MKb5c/Yha35UwPV58Pc61V5Oj91Gnzz4 hpHIKipndFBQEIJn3zpxwAEIvG2KH4Zg1mpFCw66gTsqdK8bb7a1vu5LNfilgzrxQjmp aNkiWy+f5gmevJW1AmMrHZ2NA9y0zqvNFXad4n26co9LRuLctdFZkIagwWUrDCtgCN15 PSXsUIUoNZrjx9pKqIS3GR740oiX0NiO3pOk6naMsrrCQk4yxVk1S2ohhq/F/BEOStvC K/ng== X-Gm-Message-State: AOAM530ZYBfdTRRa71td4eTEJ4Wb51lO+dtOdGzz3TGObXIJJ6HvSzSB knJN1CbEwRAZDGw0bumCsjJKF+PmSI2ykQ== X-Google-Smtp-Source: ABdhPJwcbUQCbcRhVX1+YhXE+ipgjBmQgPCYouQrz8s/BkAWq0yZcaNwHp7QooWZjxStw+E2cIbR/g== X-Received: by 2002:a2e:901a:: with SMTP id h26mr2312942ljg.412.1603997833008; Thu, 29 Oct 2020 11:57:13 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id t10sm362231lfc.258.2020.10.29.11.57.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 11:57:11 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id c21so4317224ljj.0 for ; Thu, 29 Oct 2020 11:57:10 -0700 (PDT) X-Received: by 2002:a2e:8942:: with SMTP id b2mr2536155ljk.441.1603997830537; Thu, 29 Oct 2020 11:57:10 -0700 (PDT) MIME-Version: 1.0 References: <20201028142433.18501-1-kitakar@gmail.com> <20201028142433.18501-2-kitakar@gmail.com> In-Reply-To: From: Brian Norris Date: Thu, 29 Oct 2020 11:56:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] mwifiex: disable ps_mode explicitly by default instead To: Andy Shevchenko Cc: Tsuchiya Yuto , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless , "" , Linux Kernel , Maximilian Luz , Andy Shevchenko , verdre@v0yd.nl Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 11:37 AM Andy Shevchenko wrote: > And this feeling (that it's a FW issue) what I have. But the problem > here, that Marvell didn't fix and probably won't fix their FW... Sure, I wouldn't hold your breath. So some of these tactics (disabling PS, etc.) may be valid, but you have to do them smartly, acknowledging that there are other (more stable) firmwares and chips in use for this same driver. > Just wondering if Google (and MS in their turn) use different > firmwares to what we have available in Linux. No clue about MS. But Chrom{e,ium} OS generally publishes all this stuff where possible. You can see what we use here: https://chromium.googlesource.com/chromiumos/third_party/linux-firmware/+/HEAD/mrvl/ https://chromium.googlesource.com/chromiumos/third_party/marvell/+/HEAD/ We try to stay somewhat in sync / parallel with "upstream" linux-firmware, and strongly encourage vendors to send the same binaries upstream when they hand them to us, but there are exceptions and oversights (e.g., old products might have used a different firmware branch). Notably, I'll repeat: we (Chrome OS) don't actually support the PCIe variant of 8897, so the report in question ("PCIe-88W8897") has no equivalent in a supported Chrome OS system (even if there are binaries in the links above, we don't use them). I would not be surprised if there are an enormous number of firmware bugs there, as there were initially for PCIe-88W8997 (which we do support). Brian