From: Brian Norris <briannorris@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
LKML <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>, Sean Paul <sean@poorly.run>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v3 2/2] drm/bridge: analogix_dp: Enable autosuspend
Date: Tue, 1 Mar 2022 18:03:18 -0800 [thread overview]
Message-ID: <CA+ASDXPGpJystb0uFNT8f+FSzERC0-YxVfGLRo-U1uoTRMHY6Q@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=UudBo7aZqD8oGHAu94LEYovMtFq7hjwOG2_8yxUeNi_w@mail.gmail.com>
On Tue, Feb 22, 2022 at 2:10 PM Doug Anderson <dianders@chromium.org> wrote:
> On Thu, Feb 17, 2022 at 2:42 PM Brian Norris <briannorris@chromium.org> wrote:
> > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > @@ -1121,7 +1121,7 @@ static int analogix_dp_get_modes(struct drm_connector *connector)
> >
> > pm_runtime_get_sync(dp->dev);
> > edid = drm_get_edid(connector, &dp->aux.ddc);
> > - pm_runtime_put(dp->dev);
> > + pm_runtime_put_autosuspend(dp->dev);
>
> So I think you can fully get rid of these ones now and rely on the
> ones in the aux transfer, right?
Yep, good catch.
> > if (edid) {
> > drm_connector_update_edid_property(&dp->connector,
> > edid);
> > @@ -1642,7 +1642,7 @@ static ssize_t analogix_dpaux_transfer(struct drm_dp_aux *aux,
> >
> > ret = analogix_dp_transfer(dp, msg);
> > out:
> > - pm_runtime_put(dp->dev);
> > + pm_runtime_put_autosuspend(dp->dev);
> >
> > return ret;
> > }
> > @@ -1775,6 +1775,8 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
> > if (ret)
> > return ret;
> >
> > + pm_runtime_use_autosuspend(dp->dev);
> > + pm_runtime_set_autosuspend_delay(dp->dev, 100);
>
> It's explicitly listed in the Documentation that you need the
> corresponding pm_runtime_dont_use_autosuspend(). Specifically, it
> says:
>
> > Drivers in ->remove() callback should undo the runtime PM changes done
> > in ->probe(). Usually this means calling pm_runtime_disable(),
> > pm_runtime_dont_use_autosuspend() etc.
>
> Not that it's very common to see anyone actually get it right, but I
> seem to remember running into an issue when I didn't do it. I think
> ti-sn65dsi86 still has it wrong since I found out about this later.
> Need to write a patch up for that... Basically you want to put it
> right before the two calls in your driver to pm_runtime_disable().
Ack.
Speaking of API misfeatures that we missed: I've failed to call
pm_runtime_mark_last_busy(). I'll add that in the next rev, for the
cases where we weren't already calling *_put_sync() (i.e., presumably
we don't really care to wait around for autosuspend).
*gripe* What a silly API. *gripe*
Brian
next prev parent reply other threads:[~2022-03-02 2:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 22:41 [PATCH v3 1/2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX Brian Norris
2022-02-17 22:41 ` [PATCH v3 2/2] drm/bridge: analogix_dp: Enable autosuspend Brian Norris
2022-02-22 22:09 ` Doug Anderson
2022-03-02 2:03 ` Brian Norris [this message]
2022-02-22 22:10 ` [PATCH v3 1/2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ASDXPGpJystb0uFNT8f+FSzERC0-YxVfGLRo-U1uoTRMHY6Q@mail.gmail.com \
--to=briannorris@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).