From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 359F8C433EF for ; Tue, 9 Nov 2021 18:07:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A39F60FE3 for ; Tue, 9 Nov 2021 18:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242053AbhKISJv (ORCPT ); Tue, 9 Nov 2021 13:09:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241812AbhKISJY (ORCPT ); Tue, 9 Nov 2021 13:09:24 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D9BC061205 for ; Tue, 9 Nov 2021 10:06:35 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id r26so174379oiw.5 for ; Tue, 09 Nov 2021 10:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=O+fhYkcqhMQ8k14bNZcPRV6UkOwVHbARh5DBR4w4Kpg=; b=CPnbviPehHndJcufAKnxvmQCz4mp4bEQpdeHccnDuhigP6kyJib/gphfqJKMBD9sYN oez1oJmgZmzZ9XoEAsKiegEc6B939nNhVcBQpeUfDIlRCKzPMyNeltxhWg23GOET6xug ceiQT9g16XrsJlHxHY1H3O2rBE2zM0ITmzCjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=O+fhYkcqhMQ8k14bNZcPRV6UkOwVHbARh5DBR4w4Kpg=; b=3OT5jo8Vf0hgMrZWO6lAsHIo6Rar97mRDLeservVdSifSO0xs0ofyWKHwoI6CYF558 REy5Zx5umKpakDESegODupaWwByhOo4pU1K23PzOvp7zldj2c9Nu88ZyDyzQamFG21m2 QpTS6Qg5FWvwU4llhbQK2QEGpCQf8jV0uzwIRSDdDRqXJVSA17cD0J3ZGJgnbD+dCpbt mCv2n4YxIzOLvuGyXXRcfoYBVvFDK7aqMYW5qypZYjZ+MzqYvpokL78q2b7nBUz1n37n YLakkb+xwoYlVhJ/xf7+o4RmPhHHmw2FD/g5PXylidtJ87SBpEAz4gBJMSqaqNntyc8j pqHQ== X-Gm-Message-State: AOAM532xPI4n9n8EX2+I+0ViICR6vleI5Zg0MOP4AcZEij8APrjjcHbX UPc0iOXOUsFmo6VDUdJerCEsEKbjm6W3PA== X-Google-Smtp-Source: ABdhPJxAwiSDN+oglRqQr4arZB2akxIDswAVbt4nXgQ8/9jzT0Dvki4c9Q51bEEz8jZGgoffE/zxVA== X-Received: by 2002:a05:6808:bc3:: with SMTP id o3mr7334853oik.33.1636481194356; Tue, 09 Nov 2021 10:06:34 -0800 (PST) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id z7sm3343732oib.0.2021.11.09.10.06.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 10:06:32 -0800 (PST) Received: by mail-ot1-f50.google.com with SMTP id v40-20020a056830092800b0055591caa9c6so32114525ott.4 for ; Tue, 09 Nov 2021 10:06:32 -0800 (PST) X-Received: by 2002:a9d:734a:: with SMTP id l10mr7706868otk.3.1636481191553; Tue, 09 Nov 2021 10:06:31 -0800 (PST) MIME-Version: 1.0 References: <20211109010649.1191041-1-sashal@kernel.org> <20211109010649.1191041-10-sashal@kernel.org> In-Reply-To: <20211109010649.1191041-10-sashal@kernel.org> From: Brian Norris Date: Tue, 9 Nov 2021 10:06:19 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH AUTOSEL 4.14 10/39] mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?UTF-8?Q?Jonas_Dre=C3=9Fler?= , Kalle Valo , amitkarwar@gmail.com, ganapathi017@gmail.com, sharvari.harisangam@nxp.com, huxinming820@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 8, 2021 at 5:18 PM Sasha Levin wrote: > > From: Jonas Dre=C3=9Fler > > [ Upstream commit c2e9666cdffd347460a2b17988db4cfaf2a68fb9 ] ... > This does not fix any particular bug and just "looked right", so there's > a small chance it might be a regression. I won't insist on rejecting this one, but especially given this sentence, this doesn't really pass the smell test for -stable candidates. It's stuff like this that pushes me a bit toward the camp of those who despise the ML-based selection methods here, even though it occasionally (or even often) may produce some good. Brian