From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4199C433DF for ; Fri, 15 May 2020 19:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4ACD20727 for ; Fri, 15 May 2020 19:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="DYjN1UQ+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbgEOTSA (ORCPT ); Fri, 15 May 2020 15:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726223AbgEOTR7 (ORCPT ); Fri, 15 May 2020 15:17:59 -0400 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777C1C05BD09 for ; Fri, 15 May 2020 12:17:59 -0700 (PDT) Received: by mail-ed1-x541.google.com with SMTP id s19so3093406edt.12 for ; Fri, 15 May 2020 12:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zbFsGFMIlvy1kKOGqgavt+ubA29TnTVOTBRv6vIQjH0=; b=DYjN1UQ+2UifVP6w0ZHdAS+uaK/GP/9FOFhOPYeVr635TTaqdqu+hbJhqccicAI5lx Cbo4FdRrTW0jq/ekvklHVpsOkZBAOYDwp+KcZCiioXOsJ7nN1THWpRDJ8kkCV5qWtm0g AF/+1417vIKTX3DYRaoeOUt3wKN4+Ft836iqIjoOgl+X6UJGNj2GLPekJh8DuKYjf3UE AXjUmpSfyNeiq8S37ot0NrUeGh3+vXZJaYGwsPNrz9mVCSVhK6B96CRah6XKUOsEhypz ryKvBFjGDOrNVUKj4PYHDUpHNw82luHfzbGnyDdIGkha6PdBAja9wmcuYdT0B/+oY+TA MbhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zbFsGFMIlvy1kKOGqgavt+ubA29TnTVOTBRv6vIQjH0=; b=qypiT0hUs+yuyZFHh8piAqRng/WRP1Ej7bYrFUM/N4stfxamFSa4aF/RcMp38gOouM 0CwG3FkGftICldhv7aQ5Whsfw8vkWfl3hMdz/ITg0azQu81FIE86sokj+lKEfcjRcMkO X1HJfoUqvVEatapCp7TRXf72/55JcSdCKLb8SuEXzECdVBCEKHsWyB0m7JD1qDwy4WgN cs7iK/KMbwkSXQ/cU0oJEVdY5oLAflY6SMdHy7jMOJFa+h0a69GHJGjZ+h/UG81Vg7Ry HT1oqMR81e280Dr793JZI1BfoanUuIwbJgBt0ys1xx357qvCArGjxYIgmqnwcDyk15Cn zN9g== X-Gm-Message-State: AOAM53080jkkJsC3uGORCOKMoGWWXFZEtSz5qZU5IzVSQlCVAF0P9PxC GoZLxi9oK+zbc4Q5y4Pu7w417zbzAq7BJDhNMRTx6g== X-Google-Smtp-Source: ABdhPJz0Ek3DDmLsyu6vepzg7IcDPqIXlEvChPtaCxV8HF3LZLhlke8gwyZn2f1RjvDzPYken2umNdX2JOgQpllNx+E= X-Received: by 2002:a50:ee04:: with SMTP id g4mr4273534eds.221.1589570278060; Fri, 15 May 2020 12:17:58 -0700 (PDT) MIME-Version: 1.0 References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-2-keescook@chromium.org> In-Reply-To: <20200515184434.8470-2-keescook@chromium.org> From: Pavel Tatashin Date: Fri, 15 May 2020 15:17:22 -0400 Message-ID: Subject: Re: [PATCH v4 1/6] printk: Collapse shutdown types into a single dump reason To: Kees Cook Cc: Petr Mladek , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Benson Leung , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Enric Balletbo i Serra , Sergey Senozhatsky , Steven Rostedt , Linux Doc Mailing List , LKML , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 2:44 PM Kees Cook wrote: > > To turn the KMSG_DUMP_* reasons into a more ordered list, collapse > the redundant KMSG_DUMP_(RESTART|HALT|POWEROFF) reasons into > KMSG_DUMP_SHUTDOWN. The current users already don't meaningfully > distinguish between them, so there's no need to, as discussed here: > https://lore.kernel.org/lkml/CA+CK2bAPv5u1ih5y9t5FUnTyximtFCtDYXJCpuyjOyHNOkRdqw@mail.gmail.com/ > > Signed-off-by: Kees Cook Maybe it makes sense to mention in the commit log that for all three merged cases there is a pr_emerg() message logged right before the kmsg_dump(), thus the reason is distinguishable from the dmesg log itself. Reviewed-by: Pavel Tatashin