From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Leonardo Bras <leonardo@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Michal Hocko" <mhocko@suse.com>,
"Pavel Tatashin" <pasha.tatashin@oracle.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Pasha Tatashin" <Pavel.Tatashin@microsoft.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE
Date: Thu, 18 Jul 2019 08:19:46 -0400 [thread overview]
Message-ID: <CA+CK2bBu7DnG73SaBDwf9cBceNvKnZDEqA-gBJmKC9K_rqgO+A@mail.gmail.com> (raw)
In-Reply-To: <20190718024133.3873-1-leonardo@linux.ibm.com>
On Wed, Jul 17, 2019 at 10:42 PM Leonardo Bras <leonardo@linux.ibm.com> wrote:
>
> Adds an option on kernel config to make hot-added memory online in
> ZONE_MOVABLE by default.
>
> This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y by
> allowing to choose which zone it will be auto-onlined
This is a desired feature. From reading the code it looks to me that
auto-selection of online method type should be done in
memory_subsys_online().
When it is called from device online, mem->online_type should be -1:
if (mem->online_type < 0)
mem->online_type = MMOP_ONLINE_KEEP;
Change it to:
if (mem->online_type < 0)
mem->online_type = MMOP_DEFAULT_ONLINE_TYPE;
And in "linux/memory_hotplug.h"
#ifdef CONFIG_MEMORY_HOTPLUG_MOVABLE
#define MMOP_DEFAULT_ONLINE_TYPE MMOP_ONLINE_MOVABLE
#else
#define MMOP_DEFAULT_ONLINE_TYPE MMOP_ONLINE_KEEP
#endif
Could be expanded to support MMOP_ONLINE_KERNEL as well.
Pasha
>
> Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> ---
> drivers/base/memory.c | 3 +++
> mm/Kconfig | 14 ++++++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index f180427e48f4..378b585785c1 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -670,6 +670,9 @@ static int init_memory_block(struct memory_block **memory,
> mem->state = state;
> start_pfn = section_nr_to_pfn(mem->start_section_nr);
> mem->phys_device = arch_get_memory_phys_device(start_pfn);
> +#ifdef CONFIG_MEMORY_HOTPLUG_MOVABLE
> + mem->online_type = MMOP_ONLINE_MOVABLE;
> +#endif
>
> ret = register_memory(mem);
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f0c76ba47695..74e793720f43 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -180,6 +180,20 @@ config MEMORY_HOTREMOVE
> depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
> depends on MIGRATION
>
> +config MEMORY_HOTPLUG_MOVABLE
> + bool "Enhance the likelihood of hot-remove"
> + depends on MEMORY_HOTREMOVE
> + help
> + This option sets the hot-added memory zone to MOVABLE which
> + drastically reduces the chance of a hot-remove to fail due to
> + unmovable memory segments. Kernel memory can't be allocated in
> + this zone.
> +
> + Say Y here if you want to have better chance to hot-remove memory
> + that have been previously hot-added.
> + Say N here if you want to make all hot-added memory available to
> + kernel space.
> +
> # Heavily threaded applications may benefit from splitting the mm-wide
> # page_table_lock, so that faults on different parts of the user address
> # space can be handled with less contention: split it at this NR_CPUS.
> --
> 2.20.1
>
On Wed, Jul 17, 2019 at 10:42 PM Leonardo Bras <leonardo@linux.ibm.com> wrote:
>
> Adds an option on kernel config to make hot-added memory online in
> ZONE_MOVABLE by default.
>
> This would be great in systems with MEMORY_HOTPLUG_DEFAULT_ONLINE=y by
> allowing to choose which zone it will be auto-onlined
>
> Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> ---
> drivers/base/memory.c | 3 +++
> mm/Kconfig | 14 ++++++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index f180427e48f4..378b585785c1 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -670,6 +670,9 @@ static int init_memory_block(struct memory_block **memory,
> mem->state = state;
> start_pfn = section_nr_to_pfn(mem->start_section_nr);
> mem->phys_device = arch_get_memory_phys_device(start_pfn);
> +#ifdef CONFIG_MEMORY_HOTPLUG_MOVABLE
> + mem->online_type = MMOP_ONLINE_MOVABLE;
> +#endif
>
> ret = register_memory(mem);
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f0c76ba47695..74e793720f43 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -180,6 +180,20 @@ config MEMORY_HOTREMOVE
> depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
> depends on MIGRATION
>
> +config MEMORY_HOTPLUG_MOVABLE
> + bool "Enhance the likelihood of hot-remove"
> + depends on MEMORY_HOTREMOVE
> + help
> + This option sets the hot-added memory zone to MOVABLE which
> + drastically reduces the chance of a hot-remove to fail due to
> + unmovable memory segments. Kernel memory can't be allocated in
> + this zone.
> +
> + Say Y here if you want to have better chance to hot-remove memory
> + that have been previously hot-added.
> + Say N here if you want to make all hot-added memory available to
> + kernel space.
> +
> # Heavily threaded applications may benefit from splitting the mm-wide
> # page_table_lock, so that faults on different parts of the user address
> # space can be handled with less contention: split it at this NR_CPUS.
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-07-18 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 2:41 [PATCH 1/1] mm/memory_hotplug: Adds option to hot-add memory in ZONE_MOVABLE Leonardo Bras
2019-07-18 6:12 ` Oscar Salvador
2019-07-18 15:50 ` Leonardo Bras
2019-07-18 15:57 ` Michal Hocko
2019-07-18 16:11 ` Pavel Tatashin
2019-07-18 16:40 ` Michal Hocko
2019-07-18 16:43 ` Pavel Tatashin
2019-07-18 6:26 ` Mike Rapoport
2019-07-18 12:19 ` Pavel Tatashin [this message]
2019-07-18 16:03 ` Leonardo Bras
2019-07-18 16:45 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+CK2bBu7DnG73SaBDwf9cBceNvKnZDEqA-gBJmKC9K_rqgO+A@mail.gmail.com \
--to=pasha.tatashin@soleen.com \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jglisse@redhat.com \
--cc=leonardo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@oracle.com \
--cc=rafael@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).