From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA90C432BE for ; Fri, 20 Aug 2021 17:20:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C486611AE for ; Fri, 20 Aug 2021 17:20:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233245AbhHTRUk (ORCPT ); Fri, 20 Aug 2021 13:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232598AbhHTRUj (ORCPT ); Fri, 20 Aug 2021 13:20:39 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1C42C061575 for ; Fri, 20 Aug 2021 10:20:00 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id bq25so21529096ejb.11 for ; Fri, 20 Aug 2021 10:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VG5fvfC7Y3KRpzRAEA18KK6WLNMl8L5Q75OcNDfJ9CE=; b=ikO/PAfJFQUJKrFFQ/NFHitlqiVnSUoUDXWSXtMkcNNf3CTyeoUUBonwMIloJflLz+ huCrEfJaHgg3yivM5K/LSRVwBXVVx8Cqt5AscZBDAgGk4vznRFQKdUYPARAZm0U6CIzp SAe2uTox4gKHqT+v9zOqVvPi1dVz1FzM89vkyWsaTpW0nfihPX1We9/zCONW6DGd14iu wzeMLiPOy6tH2FaUAFOcbMTg/3hdjjIdNB5IDiB+ptLssyR1OgWBCcm1laO5aK7wKbHy ftSiDq5k4ONSQlNKbgwXWoKTMviBV+PrjJsNVKoHhjGkil6MpnoXMiN17NtXMjOotIQ8 870A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VG5fvfC7Y3KRpzRAEA18KK6WLNMl8L5Q75OcNDfJ9CE=; b=NKe4NMqGdWIDrVizc/1Pu+7NrSPyjjtUro9IILsS4195uLMqSliQCk2z0jJ48HqtoO LSL0/fbnq//7ZZFw9TNihHGbY2n8A6MT6xAxzdOPp4d5LW/CWy4Jr6AQWcMwGahdfsu+ sFI01/ULpw1EsyJHm9qGqVy+J9uW3oJoO9ExZALyH4vrHJtFuaBn+h3Mx7JhcXw88iB4 yFLYQsrYYa7wS+NTLB1ueQp8jaNH4d8SXFXX+hAmWqzNXLVY7g7GmcmGfCXLg5vNQ6i2 99ga/69ZInrf5FmnpQ5yrDo1HAPlTgnG3c3xyCepYTDW8be972UOLrk9AE3rrUQROEiX Nt/A== X-Gm-Message-State: AOAM532hmiIxBmFhZlwqw5eyu8HwqcKldXtGXzZaV9EtJqxEc39LHfcz HEWct2hYK0XH9yr2QRU3zSL2GrX3pKJEYD3OrR23aQ== X-Google-Smtp-Source: ABdhPJzZ44FgY6pUApX5hPDqNCIo2OwFIw6hYut4MVzZrKycVCcmV2eZ4QHyQbe2adBLdBie0AsK7xzwIaZvqRqovFg= X-Received: by 2002:a17:906:d20a:: with SMTP id w10mr23610197ejz.426.1629479999204; Fri, 20 Aug 2021 10:19:59 -0700 (PDT) MIME-Version: 1.0 References: <318b946ac80cc9205c89d0962048378f7ce0705b.1629386192.git.zhansayabagdaulet@gmail.com> <20210819162953.GN5469@sequoia> In-Reply-To: <20210819162953.GN5469@sequoia> From: Pavel Tatashin Date: Fri, 20 Aug 2021 13:19:23 -0400 Message-ID: Subject: Re: [PATCH v3 1/2] selftests: vm: add KSM merging time test To: Tyler Hicks Cc: Zhansaya Bagdauletkyzy , Andrew Morton , linux-mm , linux-kselftest@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 12:29 PM Tyler Hicks wrote: > > On 2021-08-19 21:33:41, Zhansaya Bagdauletkyzy wrote: > > Add ksm_merge_time() function to determine speed and time needed for > > merging. The total spent time is shown in seconds while speed is > > in MiB/s. User must specify the size of duplicated memory area (in MiB) > > before running the test. > > > > The test is run as follows: ./ksm_tests -P -s 100 > > The output: > > Total size: 100 MiB > > Total time: 0.201106786 s > > Average speed: 497.248 MiB/s > > > > Signed-off-by: Zhansaya Bagdauletkyzy > > --- > > v2 -> v3: > > - no changes > > There were no changes to this patch since v2 so my previous review still > stands: > > Reviewed-by: Tyler Hicks Thank you for addressing my comments in v2. Reviewed-by: Pavel Tatashin