From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76CA1C433EF for ; Wed, 17 Nov 2021 16:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53C8461C12 for ; Wed, 17 Nov 2021 16:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239188AbhKQQri (ORCPT ); Wed, 17 Nov 2021 11:47:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231874AbhKQQrc (ORCPT ); Wed, 17 Nov 2021 11:47:32 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E5F4C061764 for ; Wed, 17 Nov 2021 08:44:33 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id g14so13892064edb.8 for ; Wed, 17 Nov 2021 08:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mk3EQIQlc769iqF40WF3/rES8RREP3zrgFFWj+6hSiI=; b=RgTmEIalg6v0Bmq8xYKdGWPG70YJJ60v3Z2MwhHUBE08nlXk3BwGXx5vU1nh3Ua7WF J9/1jdQLH5iFcxUurmvSRvKSRTNgAwFTg+9XXxG6SNUMZddXBA7Ld/CPAe/UW+b036oF EiaMYBpO8+d5QNuFs5N80udBePkVNGMM90kVJs4ZMWMTkBgDQvNZYCMdpaEKI4bkGwW8 SnslfEl71dYywRKd1gmj0JCtXkWRPmhNEGb/QzsPVWBQbLOR2FAVScOXLuLFZSqEg2QT xBE/3DJesZREbjfjPZmq8ew46H8XCj9uGulm7YJKuY8Xft1ZYPIFePqERG41ewYkfJAi FRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mk3EQIQlc769iqF40WF3/rES8RREP3zrgFFWj+6hSiI=; b=G2nlGm+AaZoUMuaT4ZmG+3vuBR0Cs0CulyHoZyXnVUxUNxeBzzqWkcnHm0DFNAaK1J zh8IvEqXAfqVN+yBxQf83QyJ31/Tu6PGAAOZIwRo303bEaIaJY0lUiX9WUAlMavZHeGl Iyg5s2KdX/HeyXiuThWFtEjtoOJSrDsAn4H92ezJEcQYp0tZ33UrwRojGVkzcywwqdDw YgttojLYaxwHqzkaN/+FxrM8Mx423FdsblrhVYmqWvNkCX6QwJL0IbirTQBy+GGHcvbU JHl64RqTp/nCCPxJTc0C8WUn5yCunOWJae48k9I8f0pFGzoO6iex613UiUuG2g3h3Uuv R6oQ== X-Gm-Message-State: AOAM530XpGjjq3YInFMjjIFqGttflItfzmq2VJIoEON/PQKMcc3ytXx1 2HqQ/fTyscwNBAWufNflmTvHi+6WuUBzSs0CKItmDw== X-Google-Smtp-Source: ABdhPJx0MbyNR612auC3mvloK/yYL0PaX5BeexgnzrhLnlbOYQHqtK/fT8+qzfBrH/s4b0DEQ/KqFm24q5GriqDCi9I= X-Received: by 2002:a05:6402:1911:: with SMTP id e17mr9414edz.43.1637167471649; Wed, 17 Nov 2021 08:44:31 -0800 (PST) MIME-Version: 1.0 References: <20211116220038.116484-1-pasha.tatashin@soleen.com> <20211116220038.116484-2-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Wed, 17 Nov 2021 11:43:55 -0500 Message-ID: Subject: Re: [RFC 1/3] mm: ptep_clear() page table helper To: Anshuman Khandual Cc: LKML , linux-mm , Linux Doc Mailing List , Andrew Morton , David Rientjes , Paul Turner , weixugc@google.com, Greg Thelen , Ingo Molnar , Jonathan Corbet , Will Deacon , Mike Rapoport , Kees Cook , Thomas Gleixner , Peter Zijlstra , masahiroy@kernel.org, Sami Tolvanen , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , frederic@kernel.org, "H. Peter Anvin" , "Aneesh Kumar K.V" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2021 at 3:52 AM Anshuman Khandual wrote: > > > > On 11/17/21 3:30 AM, Pasha Tatashin wrote: > > diff --git a/Documentation/vm/arch_pgtable_helpers.rst b/Documentation/vm/arch_pgtable_helpers.rst > > index 552567d863b8..fbe06ec75370 100644 > > --- a/Documentation/vm/arch_pgtable_helpers.rst > > +++ b/Documentation/vm/arch_pgtable_helpers.rst > > @@ -66,9 +66,11 @@ PTE Page Table Helpers > > +---------------------------+--------------------------------------------------+ > > | pte_mknotpresent | Invalidates a mapped PTE | > > +---------------------------+--------------------------------------------------+ > > -| ptep_get_and_clear | Clears a PTE | > > +| ptep_clear | Clears a PTE | > > +---------------------------+--------------------------------------------------+ > > -| ptep_get_and_clear_full | Clears a PTE | > > +| ptep_get_and_clear | Clears and returns PTE | > > ++---------------------------+--------------------------------------------------+ > > +| ptep_get_and_clear_full | Clears and returns PTE (batched PTE unmap) | > > +---------------------------+--------------------------------------------------+ > > | ptep_test_and_clear_young | Clears young from a PTE | > > +---------------------------+--------------------------------------------------+ > > Just curious. This does not have a corresponding change in mm/debug_vm_pgtable.c ? You are right, I need to replace it in mm/debug_vm_pgtable.c as well. I will do it in the next version. Thanks, Pasha