From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] mm/page_table_check: Drop all redundant EXPORT_SYMBOL()
Date: Thu, 21 Apr 2022 11:47:57 -0400 [thread overview]
Message-ID: <CA+CK2bDMqxkzmyaoi8DD7eTRG7bS-6H=U-h_SYRLDy7Y54gOmg@mail.gmail.com> (raw)
In-Reply-To: <20220421070631.1273879-1-anshuman.khandual@arm.com>
On Thu, Apr 21, 2022 at 3:05 AM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In
> this case these functions just get called only inside their wrappers. Even
> __page_table_check_zero() gets called without such an export. Just drop all
> these redundant EXPORT_SYMBOL().
>
> Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Acked-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thank you,
Pasha
> ---
> This applies on v5.18-rc3
>
> Changes in V2:
>
> - Restored EXPORT_SYMBOL for __page_table_check_pte_set() per Pasha
>
> mm/page_table_check.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/page_table_check.c b/mm/page_table_check.c
> index 2458281bff89..627c5025d786 100644
> --- a/mm/page_table_check.c
> +++ b/mm/page_table_check.c
> @@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr,
> PAGE_SIZE >> PAGE_SHIFT);
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pte_clear);
>
> void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
> pmd_t pmd)
> @@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
> PMD_PAGE_SIZE >> PAGE_SHIFT);
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pmd_clear);
>
> void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
> pud_t pud)
> @@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
> PUD_PAGE_SIZE >> PAGE_SHIFT);
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pud_clear);
>
> void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr,
> pte_t *ptep, pte_t pte)
> @@ -223,7 +220,6 @@ void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr,
> pmd_write(pmd));
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pmd_set);
>
> void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
> pud_t *pudp, pud_t pud)
> @@ -238,7 +234,6 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
> pud_write(pud));
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pud_set);
>
> void __page_table_check_pte_clear_range(struct mm_struct *mm,
> unsigned long addr,
> --
> 2.20.1
>
prev parent reply other threads:[~2022-04-21 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 7:06 [PATCH V2] mm/page_table_check: Drop all redundant EXPORT_SYMBOL() Anshuman Khandual
2022-04-21 15:47 ` Pasha Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bDMqxkzmyaoi8DD7eTRG7bS-6H=U-h_SYRLDy7Y54gOmg@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).