From: Wenchao Chen <wenchao.chen666@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Wenchao Chen <wenchao.chen@unisoc.com>,
adrian.hunter@intel.com, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
zhenxiong.lai@unisoc.com, yuelin.tang@unisoc.com,
gengcixi@gmail.com
Subject: Re: [PATCH] mmc: sdhci-sprd: remove prefer asynchronous probe
Date: Fri, 2 Dec 2022 10:41:28 +0800 [thread overview]
Message-ID: <CA+Da2qwjY=ebOmwsauPS5r8ig7wbH0JwjhDPmi1+eaT09tKxGQ@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFoBf25CDAgg5R0MSp53iC277FzGO9DUDf3LPU+_wuxCsA@mail.gmail.com>
On Thu, Dec 1, 2022 at 6:41 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Thu, 1 Dec 2022 at 10:12, Wenchao Chen <wenchao.chen@unisoc.com> wrote:
> >
> > The prefer asynchronous probe affects the order of device probes.
>
> Is there a problem with this? If so, can you elaborate on what kind of problems?
>
Hi Uffe
dts:
sdio0: sdio@71100000 {
...
bus-width = <4>;
no-sdio;
no-mmc;
...
}; // SD Host(Device: SD CARD)
sdio3: sdio@71400000 {
...
bus-width = <8>;
non-removable;
no-sdio;
no-sd;
...
}; // eMMC Host(Device: eMMC)
According to the order of DTS: sdio0: sdio@71100000 is MMC0, sdio3:
sdio@71400000 is MMC1.
Log:
[ 1.714617][ T11] mmc1: SDHCI controller on 71400000.sdio
[71400000.sdio] using ADMA 64-bit
[ 1.715276][ T9] mmc0: SDHCI controller on 71100000.sdio
[71100000.sdio] using ADMA 64-bit
[ 1.884525][ T75] mmc1: Host Software Queue enabled
[ 1.890965][ T75] mmc1: new HS400 Enhanced strobe MMC card at address 0001
But set prefer_asynchronous_probe, sometimes there will be sdio0:
sdio@71100000 is MMC1, sdio3: sdio@71400000 is MMC0.
Log:
[ 1.619888][ T68] mmc0: SDHCI controller on 71400000.sdio
[71400000.sdio] using ADMA 64-bit
[ 1.620534][ T9] mmc1: SDHCI controller on 71100000.sdio
[71100000.sdio] using ADMA 64-bit
[ 1.792570][ T77] mmc0: Host Software Queue enabled
[ 1.799532][ T77] mmc0: new HS400 Enhanced strobe MMC card at address 0001
We use emmc as rootfs (without ramfs or initfs), but with SD card
inserted and not inserted, the partition name of emmc is different, we
need to fix this partition name.
> >
> > Fixes: d86472ae8b20 ("mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v5.4")
> > Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
>
> Kind regards
> Uffe
>
> > ---
> > drivers/mmc/host/sdhci-sprd.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> > index b92a408f138d..bf8df727e95e 100644
> > --- a/drivers/mmc/host/sdhci-sprd.c
> > +++ b/drivers/mmc/host/sdhci-sprd.c
> > @@ -801,7 +801,6 @@ static struct platform_driver sdhci_sprd_driver = {
> > .remove = sdhci_sprd_remove,
> > .driver = {
> > .name = "sdhci_sprd_r11",
> > - .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> > .of_match_table = sdhci_sprd_of_match,
> > .pm = &sdhci_sprd_pm_ops,
> > },
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2022-12-02 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 9:11 [PATCH] mmc: sdhci-sprd: remove prefer asynchronous probe Wenchao Chen
2022-12-01 10:32 ` Ulf Hansson
2022-12-02 2:41 ` Wenchao Chen [this message]
2022-12-07 12:50 ` Ulf Hansson
2022-12-09 6:37 ` Wenchao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Da2qwjY=ebOmwsauPS5r8ig7wbH0JwjhDPmi1+eaT09tKxGQ@mail.gmail.com' \
--to=wenchao.chen666@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=gengcixi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wenchao.chen@unisoc.com \
--cc=yuelin.tang@unisoc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhenxiong.lai@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).