From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191E6C07E98 for ; Mon, 5 Jul 2021 07:11:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBD63613E1 for ; Mon, 5 Jul 2021 07:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbhGEHOH (ORCPT ); Mon, 5 Jul 2021 03:14:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbhGEHOG (ORCPT ); Mon, 5 Jul 2021 03:14:06 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01369C061574 for ; Mon, 5 Jul 2021 00:11:30 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id u11so19782171oiv.1 for ; Mon, 05 Jul 2021 00:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cZxArIjNZiHAGrhe17Yt+MUgYkYYP6oVJyNePuaLvQo=; b=jt+4gUW9plZiaS9YkEY8ki1HyDF9NdX/e/lcWCxHXtVTkxPsdM/atRLxcFXqW9EKoQ Yk+8PFQjcYz6Gh7CdGvunOQmap638MzLaAlLksr++j9bHRlLbL8wV5nO8nX1EWcFpoQt sbhgTYq57PEOz8AZOImm/t05oInCAxLY6CmCGLfkAt3POBqiwYogq3YKLydmmNEbdjCO CP3Y5Q8/vG+jn1uGyJDr1OUJZ0HnyhP1yka5f3m+DaUCZuRmchZwBw1HtSM8PLqvYlGE lyPVZfHn1/aqNmhTBnX7KhboGSZBOlkeQR126yinmckoYg/AQm+OmDXVrqaz5R6vWJQu libg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cZxArIjNZiHAGrhe17Yt+MUgYkYYP6oVJyNePuaLvQo=; b=Xu8hZYJxXXxLhSZORSZTdfEcxjgC9PAc/ypFgqY4Cecy0ULeh0GNxwgxJg04/CXfyF 2FLBgYwVVejZR3hkhMNz1YGN4+V3Z3D0kKTu4YX8grZhbXdS2Efiq0dw+qpgH/gUVvya 1CsEWd5lmjb2/kMyMC+pahpKFwjlvRCzPJqL4y9SQMoQFGdyR7iwQ6nYyEbFDaU19kq5 cqAk5PRv7JadeuJq/BDWrAMvHMghDq88ehzVHqjSqhH02oXSSHwQiEoQeO5VjzLixWsl d0gEV9mMdPKv1JrVzj6wOueLraRcD6AoKqtKM4jHMVrYN1nG+HVxlHqu4ibFtINEKj0o XX6A== X-Gm-Message-State: AOAM531+NMbARuN15wWMQ8QfigzzH5YkJffcoCOJSrO1agSf63lHUds8 mlqZr8KlcW/f7nimDC2DVGhN7bJ2mE7LRT4/ywy7jg== X-Google-Smtp-Source: ABdhPJwxa4HxU03oGoZBalOKZcT2rSN8GgCgw22jAVdG6FeLKxYuzpzdZSzAMBm9hF/iaaAMYRfNBM3gbYi48NnAF8c= X-Received: by 2002:a05:6808:158b:: with SMTP id t11mr9184452oiw.8.1625469089197; Mon, 05 Jul 2021 00:11:29 -0700 (PDT) MIME-Version: 1.0 References: <20210628142607.32218-1-sashal@kernel.org> <20210628142607.32218-50-sashal@kernel.org> <20210703152144.GB3004@amd> In-Reply-To: <20210703152144.GB3004@amd> From: Fuad Tabba Date: Mon, 5 Jul 2021 08:10:47 +0100 Message-ID: Subject: Re: [PATCH 5.10 049/101] KVM: selftests: Fix kvm_check_cap() assertion To: Pavel Machek Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Paolo Bonzini Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On Sat, Jul 3, 2021 at 4:21 PM Pavel Machek wrote: > > Hi! > > > From: Fuad Tabba > > > > [ Upstream commit d8ac05ea13d789d5491a5920d70a05659015441d ] > > > > KVM_CHECK_EXTENSION ioctl can return any negative value on error, > > and not necessarily -1. Change the assertion to reflect that. > > > > Signed-off-by: Fuad Tabba > > This is userland code, right? > > > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > > @@ -55,7 +55,7 @@ int kvm_check_cap(long cap) > > exit(KSFT_SKIP); > > > > ret = ioctl(kvm_fd, KVM_CHECK_EXTENSION, cap); > > - TEST_ASSERT(ret != -1, "KVM_CHECK_EXTENSION IOCTL failed,\n" > > + TEST_ASSERT(ret >= 0, "KVM_CHECK_EXTENSION IOCTL failed,\n" > > " rc: %i errno: %i", ret, errno); There's at least one case that I am aware of that potentially would return a value other than -1 on error, which is a check for KVM_CAP_MSI_DEVID (-EINVAL, -22): https://elixir.bootlin.com/linux/latest/source/arch/arm64/kvm/arm.c#L229 Also, considering that this is test code, it might be good to have the check be as strict as possible. Cheers, /fuad > And syscalls return -1 on error in userland, not anything else. So > this should not be needed. > > Best regards, > Pavel > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany