Re: [PATCH v3 5/9] mtd: spi-nor: fsl-quadspi:Support qspi for ls2080a

From: Han Xu <xhnjupt@gmail.com>
To: Yunhui Cui <B56489@freescale.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"han.xu@freescale.com" <han.xu@freescale.com>,
	jagannadh.teki@gmail.com, Yunhui Cui <yunhui.cui@nxp.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Yao Yuan <yao.yuan@nxp.com>
Subject: Re: [PATCH v3 5/9] mtd: spi-nor: fsl-quadspi:Support qspi for ls2080a
Date: Wed, 14 Sep 2016 14:46:23 -0500	[thread overview]
Message-ID: <CA+EcR20-2a37DiPEbvjJnM0KcGqQWUypXxQkzMZWefS8dzJvmQ@mail.gmail.com> (raw)
In-Reply-To: <1471505884-33996-5-git-send-email-B56489@freescale.com>

On Thu, Aug 18, 2016 at 2:38 AM, Yunhui Cui <B56489@freescale.com> wrote:
> There is a hardware feature that qspi_amba_base is added
> internally by SOC design on ls2080a. So as to software, the driver
> need support to the feature.
>
> Signed-off-by: Yunhui Cui <B56489@freescale.com>
> Signed-off-by: Yunhui Cui <yunhui.cui@nxp.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 2521370..57eed3c 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -41,6 +41,8 @@
>  #define QUADSPI_QUIRK_TKT253890                (1 << 2)
>  /* Controller cannot wake up from wait mode, TKT245618 */
>  #define QUADSPI_QUIRK_TKT245618         (1 << 3)
> +/* QSPI_AMBA_BASE is internally added by SOC design */
> +#define QUADSPI_AMBA_BASE_INTERNAL     (0x10000)
>
>  /* The registers */
>  #define QUADSPI_MCR                    0x00
> @@ -217,6 +219,7 @@ enum fsl_qspi_devtype {
>         FSL_QUADSPI_IMX7D,
>         FSL_QUADSPI_IMX6UL,
>         FSL_QUADSPI_LS1021A,
> +       FSL_QUADSPI_LS2080A,
>  };
>
>  struct fsl_qspi_devtype_data {
> @@ -270,6 +273,14 @@ static struct fsl_qspi_devtype_data ls1021a_data = {
>         .driver_data = 0,
>  };
>
> +static struct fsl_qspi_devtype_data ls2080a_data = {
> +       .devtype = FSL_QUADSPI_LS2080A,
> +       .rxfifo = 128,
> +       .txfifo = 64,
> +       .ahb_buf_size = 1024,
> +       .driver_data = QUADSPI_AMBA_BASE_INTERNAL,
> +};
> +
>  #define FSL_QSPI_MAX_CHIP      4
>  struct fsl_qspi {
>         struct spi_nor nor[FSL_QSPI_MAX_CHIP];
> @@ -312,6 +323,11 @@ static inline int needs_wakeup_wait_mode(struct fsl_qspi *q)
>         return q->devtype_data->driver_data & QUADSPI_QUIRK_TKT245618;
>  }
>
> +static inline int has_added_amba_base_internal(struct fsl_qspi *q)
> +{
> +       return q->devtype_data->driver_data & QUADSPI_AMBA_BASE_INTERNAL;
> +}
> +
>  /*
>   * R/W functions for big- or little-endian registers:
>   * The qSPI controller's endian is independent of the CPU core's endian.
> @@ -558,8 +574,11 @@ fsl_qspi_runcmd(struct fsl_qspi *q, u8 cmd, unsigned int addr, int len)
>         /* save the reg */
>         reg = qspi_readl(q, base + QUADSPI_MCR);
>
> -       qspi_writel(q, q->memmap_phy + q->chip_base_addr + addr,
> -                       base + QUADSPI_SFAR);
> +       if (has_added_amba_base_internal(q))
> +               qspi_writel(q, q->chip_base_addr + addr, base + QUADSPI_SFAR);
> +       else
> +               qspi_writel(q, q->memmap_phy + q->chip_base_addr + addr,
> +                           base + QUADSPI_SFAR);
>         qspi_writel(q, QUADSPI_RBCT_WMRK_MASK | QUADSPI_RBCT_RXBRD_USEIPS,
>                         base + QUADSPI_RBCT);
>         qspi_writel(q, reg | QUADSPI_MCR_CLR_RXF_MASK, base + QUADSPI_MCR);
> @@ -849,6 +868,7 @@ static const struct of_device_id fsl_qspi_dt_ids[] = {
>         { .compatible = "fsl,imx7d-qspi", .data = (void *)&imx7d_data, },
>         { .compatible = "fsl,imx6ul-qspi", .data = (void *)&imx6ul_data, },
>         { .compatible = "fsl,ls1021a-qspi", .data = (void *)&ls1021a_data, },
> +       { .compatible = "fsl,ls2080a-qspi", .data = (void *)&ls2080a_data, },
>         { /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, fsl_qspi_dt_ids);
> --
> 2.1.0.27.g96db324
>
>
Acked-by: Han xu <han.xu@nxp.com>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/


-- 
Sincerely,

Han XU