From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BAE4C43461 for ; Sun, 13 Sep 2020 08:11:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19B462074B for ; Sun, 13 Sep 2020 08:11:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r9F4evLN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgIMILV (ORCPT ); Sun, 13 Sep 2020 04:11:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725918AbgIMILQ (ORCPT ); Sun, 13 Sep 2020 04:11:16 -0400 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B07EC061574 for ; Sun, 13 Sep 2020 01:11:15 -0700 (PDT) Received: by mail-vs1-xe43.google.com with SMTP id j185so7813136vsc.3 for ; Sun, 13 Sep 2020 01:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U7YctZGSyKVBhhbXkYSzuib6I1E6a8FCL8qXkSbBCMk=; b=r9F4evLNjk6ew0JA4ZyP3UOrhOsulTgqkmH+ts5VguwGJbPTxi0ZmkRu1YI20AjM6E xj/5DKgISZB3IwPwhxv3rINMNdP9Erd6PDAxq/eJLfL/eht1K/OuQzyUe58sfXcVUGSn XEAzg/cXF9r09DvXat8U4Of22k2I7WQg2YED6adns1IkjBpI5aRtg3QhgqXWfQAQfCrn IkjK2hPvbVR08hY34SB+JOpmm6ztuEM6XzjzTnZKbbzRhCe6xGS2THZSwImfdONGQFwy olGSouxiJkFD5jrGitRRgP6/ckW6Dxe5PjqCKEvFAnI1DMHaDp9c93LikbiFvQUEQd8e C2cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U7YctZGSyKVBhhbXkYSzuib6I1E6a8FCL8qXkSbBCMk=; b=dauWQkzOcl+ZsPTk3KPcuG4Kk7gj/QwI1YbtPxaKN9M2kwz5pRc9bZiXjwXl6DAkq0 9SSIkhAcH6SO8wz6bUjs9fBVPYV3Xm43hjL/uQN4aEeDf7iSldHIdCtaP74HiKav1n1g zsfZ+I365v/f9hNFE3u57IDOX+7KKWNsE/c0oiPx0UeFYZIzGxJSkXjrl1I559vCfMO9 VDn6ofmlVFlZgjgiqRk7I5C/Hi//5bydKHDQuc7/tpqFULK/QcQzoz304jGOBg/XUZEK +Hf8a1j4VfQNhHNnCNAP841/Vf9bIeYaPE8y4ahTo3GSWAi+LuWWxFtvxwOLmV0QZ8SY ZtgA== X-Gm-Message-State: AOAM530+Kx8GHZ3JRdnqUmIuuD0xkijuFP74cne0HrzSALX4iS4y9bhx 9mFpyl9o9XDCmmfUVWM3BylOj1ORCeXdZg== X-Google-Smtp-Source: ABdhPJzDlpkGUG+aMuZ5l0I7GyIqrKnvjguq3g/1tHvrGQdt6oR8AfqGAglTAyAC45mOx0ykXzbkXQ== X-Received: by 2002:a05:6102:204b:: with SMTP id q11mr4925898vsr.40.1599984674014; Sun, 13 Sep 2020 01:11:14 -0700 (PDT) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com. [209.85.222.45]) by smtp.gmail.com with ESMTPSA id g197sm41649vkf.54.2020.09.13.01.11.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2020 01:11:13 -0700 (PDT) Received: by mail-ua1-f45.google.com with SMTP id j12so1771725ual.7 for ; Sun, 13 Sep 2020 01:11:12 -0700 (PDT) X-Received: by 2002:ab0:60d7:: with SMTP id g23mr4740563uam.122.1599984672429; Sun, 13 Sep 2020 01:11:12 -0700 (PDT) MIME-Version: 1.0 References: <20200911050359.25042-1-xie.he.0141@gmail.com> In-Reply-To: From: Willem de Bruijn Date: Sun, 13 Sep 2020 10:10:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next] net/packet: Fix a comment about hard_header_len and add a warning for it To: Xie He Cc: Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Network Development , linux-kernel , Eric Dumazet , Brian Norris , Cong Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2020 at 1:37 AM Xie He wrote: > > On Fri, Sep 11, 2020 at 7:32 AM Willem de Bruijn > wrote: > > > > From a quick scan, a few device types that might trigger this > > > > net/atm/clip.c > > drivers/net/wan/hdlc_fr.c > > drivers/net/appletalk/ipddp.c > > drivers/net/ppp/ppp_generic.c > > drivers/net/net_failover.c > > I have recently fixed this problem in the "net" tree in hdlc_fr.c. > > Glad to see the number of drivers that have this problem is not very big. I am concerned about adding a WARN_ON_ONCE that we already expect to fire on some platforms. Probably better to add the documentation without the warning. I know I suggested the check before, sorry for the churn, but I hadn't checked the existing state yet.