From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Sriram Krishnan <srirakr2@cisco.com>,
Andrew Morton <akpm@linux-foundation.org>,
xe-linux-external@cisco.com,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] AF_PACKET doesnt strip VLAN information
Date: Tue, 1 Oct 2019 11:52:11 -0400 [thread overview]
Message-ID: <CA+FuTScbrrjBucQ0YvncyAFaO5DAoDywgjn8LFt2p0NVusOErg@mail.gmail.com> (raw)
In-Reply-To: <20191001084427.73f130c0@hermes.lan>
On Tue, Oct 1, 2019 at 11:44 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Mon, 30 Sep 2019 11:16:14 -0400
> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>
> > On Mon, Sep 30, 2019 at 1:24 AM Sriram Krishnan <srirakr2@cisco.com> wrote:
> > >
> > > When an application sends with AF_PACKET and places a vlan header on
> > > the raw packet; then the AF_PACKET needs to move the tag into the skb
> > > so that it gets processed normally through the rest of the transmit
> > > path.
> > >
> > > This is particularly a problem on Hyper-V where the host only allows
> > > vlan in the offload info.
> >
> > This sounds like behavior that needs to be addressed in the driver, instead?
>
> This was what we did first, but the problem was more general.
> For example, many filtering functions assume that vlan tag is in
> skb meta data, not the packet data itself.
Out of curiosity, can you share an example?
> Therefore AF_PACKET would
> get around any filter rules.
Packet sockets are not the only way to inject packets into the kernel.
This probably also affects tap.
prev parent reply other threads:[~2019-10-01 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 4:58 [PATCH] AF_PACKET doesnt strip VLAN information Sriram Krishnan
2019-09-30 15:16 ` Willem de Bruijn
2019-10-01 15:44 ` Stephen Hemminger
2019-10-01 15:52 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTScbrrjBucQ0YvncyAFaO5DAoDywgjn8LFt2p0NVusOErg@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=srirakr2@cisco.com \
--cc=stephen@networkplumber.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).