From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
David Laight <David.Laight@aculab.com>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Soheil Hassas Yeganeh <soheil.kdev@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Shuo Chen <shuochen@google.com>,
linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2
Date: Thu, 10 Dec 2020 12:33:51 -0500 [thread overview]
Message-ID: <CA+FuTSdPir68M9PwhuCkd_Saz-Wi3xa_rNuwvbNmpAkMjOqhuA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a2WifcGmmFzSLC4-0SKsv0RT231P6TVKpWm=j927ykmQg@mail.gmail.com>
On Sat, Nov 21, 2020 at 4:27 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Fri, Nov 20, 2020 at 11:28 PM Willem de Bruijn
> <willemdebruijn.kernel@gmail.com> wrote:
> > On Fri, Nov 20, 2020 at 2:23 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > > On Fri, Nov 20, 2020 at 5:01 PM Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
> >
> > I think it'll be better to split the patchsets:
> >
> > epoll: convert internal api to timespec64
> > epoll: add syscall epoll_pwait2
> > epoll: wire up syscall epoll_pwait2
> > selftests/filesystems: expand epoll with epoll_pwait2
> >
> > and
> >
> > select: compute slack based on relative time
> > epoll: compute slack based on relative time
> >
> > and judge the slack conversion on its own merit.
>
> Yes, makes sense.
>
> > I also would rather not tie this up with the compat deduplication.
> > Happy to take a stab at that though. On that note, when combining
> > functions like
> >
> > int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp,
> > fd_set __user *exp, struct timespec64 *end_time,
> > u64 slack)
> >
> > and
> >
> > static int compat_core_sys_select(int n, compat_ulong_t __user *inp,
> > compat_ulong_t __user *outp, compat_ulong_t __user *exp,
> > struct timespec64 *end_time, u64 slack)
> >
> > by branching on in_compat_syscall() inside get_fd_set/set_fd_set and
> > deprecating their compat_.. counterparts, what would the argument
> > pointers look like? Or is that not the approach you have in mind?
>
> In this case, the top-level entry points becomes unified, and you get
> the prototype from core_sys_select() with the native arguments.
>
> I would imagine this can be done like the way I proposed
> for get_bitmap() in sys_migrate_pages:
>
> https://lore.kernel.org/lkml/20201102123151.2860165-4-arnd@kernel.org/
Coming back to this. Current patchset includes new select and poll
selftests to verify the changes. I need to send a small kselftest
patch for that first.
Assuming there's no time pressure, I will finish up and send the main
changes after the merge window, for the next release then.
Current state against linux-next at
https://github.com/wdebruij/linux-next-mirror/tree/select-compat-1
next prev parent reply other threads:[~2020-12-10 17:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:46 [PATCH v3 0/2] add epoll_pwait2 syscall Willem de Bruijn
2020-11-18 14:46 ` [PATCH v3 1/2] epoll: add nsec timeout support with epoll_pwait2 Willem de Bruijn
2020-11-18 15:00 ` Matthew Wilcox
2020-11-18 15:10 ` Willem de Bruijn
2020-11-18 15:37 ` Arnd Bergmann
2020-11-18 15:59 ` David Laight
2020-11-19 14:19 ` Willem de Bruijn
2020-11-19 14:31 ` Matthew Wilcox
2020-11-19 15:37 ` Willem de Bruijn
2020-11-19 15:45 ` Arnd Bergmann
2020-11-19 20:13 ` Willem de Bruijn
2020-11-20 8:13 ` Arnd Bergmann
2020-11-20 16:01 ` Willem de Bruijn
2020-11-20 19:23 ` Arnd Bergmann
2020-11-20 22:28 ` Willem de Bruijn
2020-11-21 9:27 ` Arnd Bergmann
2020-12-10 17:33 ` Willem de Bruijn [this message]
2020-12-10 20:34 ` Arnd Bergmann
2020-12-10 22:59 ` Willem de Bruijn
2021-01-11 20:06 ` Willem de Bruijn
2020-11-18 16:21 ` Willem de Bruijn
2020-11-18 16:50 ` Arnd Bergmann
2020-11-19 3:22 ` Willem de Bruijn
2020-11-18 14:46 ` [PATCH manpages RFC] epoll_wait.2: add epoll_pwait2 Willem de Bruijn
2020-11-18 14:46 ` [PATCH v3 2/2] selftests/filesystems: expand epoll with epoll_pwait2 Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSdPir68M9PwhuCkd_Saz-Wi3xa_rNuwvbNmpAkMjOqhuA@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=shuochen@google.com \
--cc=soheil.kdev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).