From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0943AC55179 for ; Thu, 29 Oct 2020 17:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D46120790 for ; Thu, 29 Oct 2020 17:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GgNxjbKi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbgJ2RFR (ORCPT ); Thu, 29 Oct 2020 13:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbgJ2RFQ (ORCPT ); Thu, 29 Oct 2020 13:05:16 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 048E8C0613D2 for ; Thu, 29 Oct 2020 10:05:16 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id w25so1905001vsk.9 for ; Thu, 29 Oct 2020 10:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WPCxo8dZVoPntUDqM2K1mljtNcAGM6ErEoqv5xxnH0E=; b=GgNxjbKiB0mMhC0k0NjJxuIk4xp6/uBwunh+BV5axtlic73wSrFYm6DTwllRXhN2fB qp0kLs07xY68okdCMuHAU02Y2Dozue63p6bEo93wqPSHnr+abrKlwbmVKHDGK2jAekkZ DaZ+Jwt/y7jWMNa9bFN1iYTPZzPJv3ELgoMUB7EccDCVV7Ftp3KLpBxxZoG8a2VR8/Rd r0U9EyBT1WZzrLj3Y0VvngbS6rmE7dWLcTDn0PPtLELLWPVhx36XxSj0zxs7LudSm2+l VbmU0/lmAPTj++H/QJdPcP7RjiEG8qXsd+/AngGr/yXddjYIkSC6f7q5NK1cxbEa1IEH R+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WPCxo8dZVoPntUDqM2K1mljtNcAGM6ErEoqv5xxnH0E=; b=ZBI8WFi0qPugoGCSaEoMDJXWcha3/uBqnxti2oetXJoGoL9SpvUSN5TDd21XOwLCWm ACCxefPKYZZ6nx9rjC36GFdvVS6YkZxezlnWTykBWIBUvy53FvQrGXgHQRA9GkqANqXY QhqdDSYzzrJnXeSTq7q4/xQmElwnz4FY4aeGr4FtosbaHL14AkpsGkrgUOyjKpGeJsfS HutZxzncMmNb21Cc/OMOLVNjsZaOLSjdkwCU4GolEc5FR79W2A+acValUh/YmGJ50PXc 9D+x896TKhMpt+Gu7iq1XoOqJCtAa7h2lrOdviCFVVb6Py1qZF83h7uWXxPYj8NmMop6 qDDQ== X-Gm-Message-State: AOAM531Xv8UxYjtJ2LMg/bSnx/w2oaUXjvVUPb8c8cCZUX9YfgM6ynLD DvS7ETuKHpl1upLpREqdsw37y0mRhJw= X-Google-Smtp-Source: ABdhPJwV5lk5JwZQMSeLBxc/kRXolkWAVucKl0hiPuqNQDb6IbJQBQ1l30eAUqQlliJePfWnE3VSuQ== X-Received: by 2002:a67:ec56:: with SMTP id z22mr2281874vso.6.1603991113976; Thu, 29 Oct 2020 10:05:13 -0700 (PDT) Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com. [209.85.217.44]) by smtp.gmail.com with ESMTPSA id v18sm381116uat.5.2020.10.29.10.05.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 10:05:12 -0700 (PDT) Received: by mail-vs1-f44.google.com with SMTP id b129so1936255vsb.1 for ; Thu, 29 Oct 2020 10:05:12 -0700 (PDT) X-Received: by 2002:a67:f88e:: with SMTP id h14mr3250923vso.22.1603991111738; Thu, 29 Oct 2020 10:05:11 -0700 (PDT) MIME-Version: 1.0 References: <20201028142433.18501-1-kitakar@gmail.com> <20201028142433.18501-3-kitakar@gmail.com> In-Reply-To: From: Willem de Bruijn Date: Thu, 29 Oct 2020 13:04:34 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter To: Brian Norris Cc: Tsuchiya Yuto , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless , "" , Linux Kernel , Maximilian Luz , Andy Shevchenko , verdre@v0yd.nl Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2020 at 9:13 PM Brian Norris wrote: > > On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto wrote: > > > > To make the ps_mode (power_save) control easier, this commit adds a new > > module parameter allow_ps_mode and set it false (disallowed) by default. This sounds like some form of access control, not something that makes power control "easier"? What exactly is the use case. Also, module params in networking devices are discouraged.