From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA44EC433ED for ; Thu, 13 May 2021 12:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDBF16127A for ; Thu, 13 May 2021 12:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233796AbhEMMZZ (ORCPT ); Thu, 13 May 2021 08:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233773AbhEMMZJ (ORCPT ); Thu, 13 May 2021 08:25:09 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71AAFC061763 for ; Thu, 13 May 2021 05:23:59 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id n2so39576843ejy.7 for ; Thu, 13 May 2021 05:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O/EgZ0Mib/f1h1pn6ynsix9LbKLcelscbkr1YNLcxt0=; b=tCXa270jHTARQ+SrPRUuPKjez1uo4RI0PDczBLDyslWWXw5kc8l/rKW/hg/e0ObEC5 9vF6BFhmbnrL1EizRV+UeRzphaQXA3XLTCh3aRPFPt/gDbBhIm9RLXj33bEc+mNNAQH5 CXgvNyTXpmQkBzZHu40ZzdG5wdLWNh06ZAZmXoiNdd8sSlLTu2/PbTqWgSQi1zfNLb89 obXXqRFErYFjFrxXhsgP7jLVHT8Ct6F6KTkP3dUoni7Skl/Z+RIm0CzJHXGe5lalfY2n DY+PrAL/q2XtreThld8QGQlWTo5+4BCYszLN4HMiS43J0vVmMlQVzVjcn9KJjLvYuvFK hk/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O/EgZ0Mib/f1h1pn6ynsix9LbKLcelscbkr1YNLcxt0=; b=U/7VdMticnetCoUK/HWlvz7gBI1/ghX2f5YYkIRcFFH7E+PP6X/zOD4D1k71MEYPjY o3Yzo2UV7pfUUO5cEcPtWQKtZsLqpm14wKZKrp7Jhr0MPbL4q9G2Uqtm8bg7XiEomYei wXcnj2b5HXb8ck8jMfxKjiXdYVHF6xwy5NZy4rlNc/njvlKR6f/sLvpAQPsBNt6r4q5l 10yOlf4uDenMrw1ByT8tzZWHx8DDWD0EjxJl+Md7pTN41evjmZbmLnMIqpIRZ8OkL1+L qDk1zPhApu9LWSJTXfWL4JBHmi59oNmPSmqr2ZWap7/LUXW/x5iSyj83tlQhnip3/zcU Cc2A== X-Gm-Message-State: AOAM531htxGT2btRgI3Bda/3CArbckLkcq7VQbI+E5DcsPka4Lm7V6OY a52RNfF8To2PXizyY8Sh6/7x+WAoFkwxTV8KkQ/PnQ== X-Google-Smtp-Source: ABdhPJzKsGAqpkUcIG97jIx+mrSeLSOY0Z3A2rGv49qhwxB5VfeKopzZ4b9Kyxf2I5g3UyueWtekoNaK6tdTEvYDh5w= X-Received: by 2002:a17:906:c211:: with SMTP id d17mr8276408ejz.247.1620908638026; Thu, 13 May 2021 05:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20210512144743.039977287@linuxfoundation.org> In-Reply-To: From: Naresh Kamboju Date: Thu, 13 May 2021 17:53:46 +0530 Message-ID: Subject: Re: [PATCH 5.4 000/244] 5.4.119-rc1 review To: Alexandru Elisei Cc: Greg Kroah-Hartman , open list , Shuah Khan , Florian Fainelli , patches@kernelci.org, lkft-triage@lists.linaro.org, Jon Hunter , linux-stable , Pavel Machek , Andrew Morton , Linus Torvalds , Guenter Roeck , Marc Zyngier , Linux ARM , kvmarm@lists.cs.columbia.edu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, On Wed, 12 May 2021 at 22:29, Alexandru Elisei wrote: > > Hi Naresh, > > Thank you for the report! > > On 5/12/21 5:47 PM, Naresh Kamboju wrote: > > On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman > > wrote: > >> This is the start of the stable review cycle for the 5.4.119 release. > >> There are 244 patches in this series, all will be posted as a response > >> to this one. If anyone has any issues with these being applied, please > >> let me know. > >> > >> Responses should be made by Fri, 14 May 2021 14:47:09 +0000. > >> Anything received after that time might be too late. > >> > >> The whole patch series can be found in one patch at: > >> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz > >> or in the git tree and branch at: > >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y > >> and the diffstat can be found below. > >> > >> thanks, > >> > >> greg k-h > > Build regression detected. > > > >> Alexandru Elisei > >> KVM: arm64: Initialize VCPU mdcr_el2 before loading it > > stable rc 5.4 arm axm55xx_defconfig builds failed due to these > > warnings / errors. > > - arm (axm55xx_defconfig) with gcc-8,9 and 10 failed > > > > arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init': > > arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit > > declaration of function 'kvm_arm_vcpu_init_debug'; did you mean > > 'kvm_arm_init_debug'? [-Werror=implicit-function-declaration] > > kvm_arm_vcpu_init_debug(vcpu); > > ^~~~~~~~~~~~~~~~~~~~~~~ > > kvm_arm_init_debug > > cc1: some warnings being treated as errors > > This is my fault, in Linux v5.4 KVM for arm is still around, and there's no > prototype for the function when compiling for arm. I suspect that's also the case > for v4.19. > > I made this change to get it to build: > > $ git diff > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > index dd03d5e01a94..32564b017ba0 100644 > --- a/arch/arm/include/asm/kvm_host.h > +++ b/arch/arm/include/asm/kvm_host.h > @@ -335,6 +335,7 @@ static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, > int cpu) {} > static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > static inline void kvm_arm_init_debug(void) {} > +static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {} > static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {} > static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {} > static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {} > > which matches the stub for kvm_arm_init_debug(). I can spin a patch out of it and > send it for 5.4 and 4.19. Marc, what do you think? FYI, This proposed fix patch applied and built PASS on the arm. (you may apply this patch for the next round of stable rc review) - Naresh