linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error
@ 2020-06-17  6:56 Naresh Kamboju
  2020-06-17 13:49 ` Naresh Kamboju
  2020-06-21  7:40 ` Bjorn Andersson
  0 siblings, 2 replies; 4+ messages in thread
From: Naresh Kamboju @ 2020-06-17  6:56 UTC (permalink / raw)
  To: linux-arm-msm, inux-remoteproc, linux-kernel
  Cc: sibis, vinod.koul, agross, ohad, bjorn.andersson, p.zabel,
	Naresh Kamboju

This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c

Build error:
 ../drivers/remoteproc/qcom_q6v5_mss.c:
  In function ‘q6v5_mpss_init_image’:
 ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
  error: implicit declaration of function ‘kfree’;
  did you mean ‘vfree’? [-Werror=implicit-function-declaration]
   772 |   kfree(metadata);
       |   ^~~~~
       |   vfree

Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index feb70283b6a2..903b2bb97e12 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -26,6 +26,7 @@
 #include <linux/reset.h>
 #include <linux/soc/qcom/mdt_loader.h>
 #include <linux/iopoll.h>
+#include <linux/slab.h>
 
 #include "remoteproc_internal.h"
 #include "qcom_common.h"
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error
  2020-06-17  6:56 [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error Naresh Kamboju
@ 2020-06-17 13:49 ` Naresh Kamboju
  2020-06-21  7:40 ` Bjorn Andersson
  1 sibling, 0 replies; 4+ messages in thread
From: Naresh Kamboju @ 2020-06-17 13:49 UTC (permalink / raw)
  To: linux-arm-msm, open list, linux-remoteproc
  Cc: Sibi Sankar, Vinod Koul, agross, Ohad Ben Cohen, Bjorn Andersson,
	Philipp Zabel

+ linux-remoteproc@vger.kernel.org

On Wed, 17 Jun 2020 at 12:27, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
>
> Build error:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:
>   In function ‘q6v5_mpss_init_image’:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
>   error: implicit declaration of function ‘kfree’;
>   did you mean ‘vfree’? [-Werror=implicit-function-declaration]
>    772 |   kfree(metadata);
>        |   ^~~~~
>        |   vfree
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a2..903b2bb97e12 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -26,6 +26,7 @@
>  #include <linux/reset.h>
>  #include <linux/soc/qcom/mdt_loader.h>
>  #include <linux/iopoll.h>
> +#include <linux/slab.h>
>
>  #include "remoteproc_internal.h"
>  #include "qcom_common.h"
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error
  2020-06-17  6:56 [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error Naresh Kamboju
  2020-06-17 13:49 ` Naresh Kamboju
@ 2020-06-21  7:40 ` Bjorn Andersson
  2020-06-22  6:18   ` Naresh Kamboju
  1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2020-06-21  7:40 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: linux-arm-msm, inux-remoteproc, linux-kernel, sibis, vinod.koul,
	agross, ohad, p.zabel, linux-remoteproc

On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:

> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
> 
> Build error:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:
>   In function ‘q6v5_mpss_init_image’:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
>   error: implicit declaration of function ‘kfree’;
>   did you mean ‘vfree’? [-Werror=implicit-function-declaration]
>    772 |   kfree(metadata);
>        |   ^~~~~
>        |   vfree
> 
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Thanks for the patch Naresh, it looks correct but I've not seen this
build error myself. Could you please let me know what you built to get
this and if you have any suggestion on what caused it? (So we can add a
Fixes: tag etc)

Regards,
Bjorn

> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a2..903b2bb97e12 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -26,6 +26,7 @@
>  #include <linux/reset.h>
>  #include <linux/soc/qcom/mdt_loader.h>
>  #include <linux/iopoll.h>
> +#include <linux/slab.h>
>  
>  #include "remoteproc_internal.h"
>  #include "qcom_common.h"
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error
  2020-06-21  7:40 ` Bjorn Andersson
@ 2020-06-22  6:18   ` Naresh Kamboju
  0 siblings, 0 replies; 4+ messages in thread
From: Naresh Kamboju @ 2020-06-22  6:18 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: linux-arm-msm, inux-remoteproc, open list, Sibi Sankar,
	Vinod Koul, agross, Ohad Ben Cohen, Philipp Zabel,
	linux-remoteproc

On Sun, 21 Jun 2020 at 13:12, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:
>
> > This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
> >
> > Build error:
> >  ../drivers/remoteproc/qcom_q6v5_mss.c:
> >   In function ‘q6v5_mpss_init_image’:
> >  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
> >   error: implicit declaration of function ‘kfree’;
> >   did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> >    772 |   kfree(metadata);
> >        |   ^~~~~
> >        |   vfree
> >
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Thanks for the patch Naresh, it looks correct but I've not seen this
> build error myself. Could you please let me know what you built to get
> this and if you have any suggestion on what caused it? (So we can add a
> Fixes: tag etc)

Thanks for the review.
This was an arm64 modules build failure on linux -next 20200616 tag.
This fix has already been taken care of by
Herbert Xu <herbert@gondor.apana.org.au> and got merged.
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")

ref:
https://lore.kernel.org/lkml/20200616010502.GA28834@gondor.apana.org.au/

- Naresh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-22  6:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17  6:56 [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error Naresh Kamboju
2020-06-17 13:49 ` Naresh Kamboju
2020-06-21  7:40 ` Bjorn Andersson
2020-06-22  6:18   ` Naresh Kamboju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).