From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8464C6E617 for ; Thu, 22 Feb 2024 20:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708635550; cv=none; b=saufHP+lXUywZo+dlxg4rET552PnpW4S/+cIHBzzdYjoljC9AjhnaCa0hOCEyYZ+4NWtyR97osSREC+ZLibZaLp2gTYCGt4FMr+ugXEjOEN+FtNbE1XjfU7ymEWkKEwBny1v20Nr08E73Cd38Zx05bDmlpaKgQl/pYv5m7zh62c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708635550; c=relaxed/simple; bh=C4F7mlB1MqkcQcSyoJUPRfFHjf+dal0cew/+pSwHCXo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=WL0UOWIIyGhFliMwr1RdILFTMtJ91Ca+09a6AYZsKIdkcJu1ILmXIddxIQ1EKHr2KaygPJsEKFA17ch0ZKeMdaRU97z4opr8gljYpWejBGL41fIoOLJY6v/vd8WHSAH57L0+FkV35tProslF2NYPMj4wGgmbrz2mOD469tPtmqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=MOHJAqqc; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MOHJAqqc" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-42e2507c6e1so82171cf.1 for ; Thu, 22 Feb 2024 12:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708635546; x=1709240346; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/zEWuRWWHcJcQcinmF9Ig0PacXm/lMdwIIHptRGDzpU=; b=MOHJAqqcAnRE2NSLZhyESs/g5WAAwqx5bZyPaxifPADGalK3WQEz1I3/0pCW5PdqkI ppGl1SyQhYFGzNy3SRnVVLTY8Q1L8ClG3FqEJkJFXqganGsY65/lTMo5K9QmgtbfBQBT /MeX8JzP/yxOS/GN9tRwdo5b9tqFO67Q3SN5n3ZFQmGAOoKwdOojExjprnKpJnkBuAye J/xcM0eZbNV01MeMB6Zn38/zOZ0fXEcY92HQMr85IBGcDe7q1sFoYO+RTn8ebga0c6zy PEdTG+3lch6bIe0ZKqq+1kwFgOLk1lc9vRg49EcN0d0xSJgE9xzi9uGljq5REEQ/s7/E Vqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708635546; x=1709240346; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/zEWuRWWHcJcQcinmF9Ig0PacXm/lMdwIIHptRGDzpU=; b=JFoMSaGOSo4UL7kfi2XRyiQfjdi6H8ee+/Ly/e9fevY9JuLFeseeZNDyZK2i40lcfg Nt/k7PsHcEQXxX/svAIwWSdBK73YpTM7KhlO6ma0lkSZsrLEfINVoEhKZT7c9qOtYfJu dnRv8dp0O2iBLHcWq7y1P/0T2+SkYPbDgxWTne6LwWtlE7Mkflu7hNgZw3AbzoWlO3za iKuoATuWGRoyCB6FgMkBM2eWdg+ih/5rFIA4qBO8pFst34pQjgaeVJkHQb5Vx4sr45Bl GCjfJEIhyTc+BFjw8fQnvBMP3TPvwJbxY6zoIhtOGDxqpj0Kq1OMG82EVLT87Ol8Ry1i zvdw== X-Forwarded-Encrypted: i=1; AJvYcCUIr6+vFXqH0Qg/HQOWaJPnZS743qYswHBuSO8RdnlRsEgH4tL+BVOSIsL+rPcscrQhd+qFI0qxXD707QvhMPaqULakZPlEw/sJEv+8 X-Gm-Message-State: AOJu0Yx/mKbyZ35/kUtYyAh9Qz356gzA8C+SzPCOFPIUyzkSRQstKUFa wyUjG2WGM5s10yDFK2s+YYO49iLcw5n+Hn29rB+LepRYTloE8IqdT82pLmsDAeCetCSK/Tc9OqV dbdmRYAOiFPHw51KPIZb9VzfcDAKi0GzElwFh X-Google-Smtp-Source: AGHT+IFSpfaLdIKihK3iEVOja+3Eqku3dKQtV6o3yrUl8zcXbBHUkfm22S3h1VkUJApYDgRUGbJE0TXcXoTj3FcGfX4= X-Received: by 2002:ac8:7643:0:b0:42e:1260:c4e6 with SMTP id i3-20020ac87643000000b0042e1260c4e6mr732606qtr.10.1708635546371; Thu, 22 Feb 2024 12:59:06 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221092728.1281499-1-davidgow@google.com> <20240221092728.1281499-2-davidgow@google.com> In-Reply-To: <20240221092728.1281499-2-davidgow@google.com> From: Rae Moar Date: Thu, 22 Feb 2024 15:58:54 -0500 Message-ID: Subject: Re: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test To: David Gow Cc: Linus Torvalds , Shuah Khan , Guenter Roeck , Matthew Auld , Arunpravin Paneer Selvam , =?UTF-8?Q?Christian_K=C3=B6nig?= , Kees Cook , =?UTF-8?B?TWHDrXJhIENhbmFs?= , Rodrigo Vivi , Matthew Brost , Willem de Bruijn , Florian Westphal , Cassio Neri , Javier Martinez Canillas , Arthur Grillo , Brendan Higgins , Daniel Latypov , Stephen Boyd , David Airlie , Maxime Ripard , "David S . Miller" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 21, 2024 at 4:28=E2=80=AFAM David Gow wro= te: > > KUnit's executor_test logs the filter string in KUNIT_ASSERT_EQ_MSG(), > but passed a random character from the filter, rather than the whole > string. > > This was found by annotating KUNIT_ASSERT_EQ_MSG() to let gcc validate > the format string. > > Fixes: 76066f93f1df ("kunit: add tests for filtering attributes") > Signed-off-by: David Gow Hello! This change looks good to me. Thanks for fixing this mistake. Thanks! -Rae Reviewed-by: Rae Moar > --- > lib/kunit/executor_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c > index 22d4ee86dbed..3f7f967e3688 100644 > --- a/lib/kunit/executor_test.c > +++ b/lib/kunit/executor_test.c > @@ -129,7 +129,7 @@ static void parse_filter_attr_test(struct kunit *test= ) > GFP_KERNEL); > for (j =3D 0; j < filter_count; j++) { > parsed_filters[j] =3D kunit_next_attr_filter(&filter, &er= r); > - KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter= '%s'", filters[j]); > + KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter= from '%s'", filters); > } > > KUNIT_EXPECT_STREQ(test, kunit_attr_filter_name(parsed_filters[0]= ), "speed"); > -- > 2.44.0.rc0.258.g7320e95886-goog >