From: Doug Meyer <dmeyer@gigaio.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: kurt.schwemmer@microsemi.com, linux-pci@vger.kernel.org,
linux-ntb <linux-ntb@googlegroups.com>,
Bjorn Helgaas <bhelgaas@google.com>, Jon Mason <jdmason@kudzu.us>,
"Jiang, Dave" <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On
Date: Tue, 22 May 2018 14:08:27 -0700 [thread overview]
Message-ID: <CA+GK6enp==Xb8w2mCCJGuJwWNNPuseuS-jvp00cVszgWvfbODA@mail.gmail.com> (raw)
In-Reply-To: <a0997fec-ba06-0d1d-a43d-fcc1600484f5@deltatee.com>
[resending because I forgot the mailing lists want plain text mode]
Dear Logan,
I agree. I'll add pci_disable_device().
Blessings,
Doug
On Thu, May 17, 2018 at 8:48 AM, Logan Gunthorpe <logang@deltatee.com> wrote:
>
> Thanks for your hard work on this Doug!
>
> On 17/05/18 06:00 AM, dmeyer@gigaio.com wrote:
>
> > + if (pci_enable_device(pdev)) {
> > + dev_err(&pdev->dev, "Cannot enable Switchtec device\n");
> > + return;
> > + }
>
> I suspect we should probably cass pci_disable_device() before leaving
> this function so it's in the same state we started. Just like we unmap
> the mmio.
>
> Logan
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/a0997fec-ba06-0d1d-a43d-fcc1600484f5%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2018-05-22 21:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 12:00 [PATCH 0/2] PCI Quirk Patchset for Microsemi Switchtec NTB dmeyer
2018-05-17 12:00 ` [PATCH 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header dmeyer
2018-05-17 13:25 ` Bjorn Helgaas
2018-05-17 12:00 ` [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On dmeyer
2018-05-17 13:45 ` Bjorn Helgaas
2018-05-17 16:06 ` Logan Gunthorpe
[not found] ` <CA+GK6en+g+T9H0sOMdVXv-_aD3rRcuzZ1JdfK0moEoTuuJnrqQ@mail.gmail.com>
2018-05-22 21:51 ` Bjorn Helgaas
2018-05-22 22:13 ` Alex Williamson
2018-05-22 22:23 ` Logan Gunthorpe
2018-05-23 13:33 ` Bjorn Helgaas
2018-05-23 20:21 ` Logan Gunthorpe
2018-05-17 15:48 ` Logan Gunthorpe
2018-05-22 21:08 ` Doug Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+GK6enp==Xb8w2mCCJGuJwWNNPuseuS-jvp00cVszgWvfbODA@mail.gmail.com' \
--to=dmeyer@gigaio.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).