linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Orson Zhai <orsonzhai@gmail.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: airlied@linux.ie, Daniel Vetter <daniel@ffwll.ch>,
	Baolin Wang <baolin.wang7@gmail.com>,
	Lyra Zhang <zhang.lyra@gmail.com>,
	dri-devel@lists.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
Date: Sun, 26 Jun 2022 11:46:15 +0800	[thread overview]
Message-ID: <CA+H2tpHf-LoJE45-OJ17M4r9oE7_ruitvq9P4tk8odQBiw0YPg@mail.gmail.com> (raw)
In-Reply-To: <20220624005036.37268-1-yang.lee@linux.alibaba.com>

On Fri, Jun 24, 2022 at 8:50 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/sprd/sprd_dpu.c:808:2-9: line 808 is redundant because platform_get_irq() already prints an error
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Orson Zhai <orsonzhai@gmail.com>

> ---
>  drivers/gpu/drm/sprd/sprd_dpu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
> index 3664089b6983..de4848dc0d22 100644
> --- a/drivers/gpu/drm/sprd/sprd_dpu.c
> +++ b/drivers/gpu/drm/sprd/sprd_dpu.c
> @@ -804,10 +804,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu,
>         }
>
>         ctx->irq = platform_get_irq(pdev, 0);
> -       if (ctx->irq < 0) {
> -               dev_err(dev, "failed to get dpu irq\n");
> +       if (ctx->irq < 0)
>                 return ctx->irq;
> -       }
>
>         /* disable and clear interrupts before register dpu IRQ. */
>         writel(0x00, ctx->base + REG_DPU_INT_EN);
> --
> 2.20.1.7.g153144c
>

  reply	other threads:[~2022-06-26  3:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  0:50 [PATCH -next] drm: Remove unnecessary print function dev_err() Yang Li
2022-06-26  3:46 ` Orson Zhai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-07  1:47 Yang Li
2022-06-13  1:26 Yang Li
2022-06-24 15:00 ` Paul Kocialkowski
2022-06-24 15:26   ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+H2tpHf-LoJE45-OJ17M4r9oE7_ruitvq9P4tk8odQBiw0YPg@mail.gmail.com \
    --to=orsonzhai@gmail.com \
    --cc=airlied@linux.ie \
    --cc=baolin.wang7@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yang.lee@linux.alibaba.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).