From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFF8C433FE for ; Thu, 23 Sep 2021 18:15:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3D2561211 for ; Thu, 23 Sep 2021 18:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242716AbhIWSQz (ORCPT ); Thu, 23 Sep 2021 14:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242677AbhIWSQy (ORCPT ); Thu, 23 Sep 2021 14:16:54 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E34C061756 for ; Thu, 23 Sep 2021 11:15:22 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id a20so7580153ilq.7 for ; Thu, 23 Sep 2021 11:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=72ITZJBpbIG9VsQo2cUy5Im243aqBGys0mIv1iVxo/w=; b=o9EV9SFJsg8+YWDc8nqXN1Aa/pU/I1MMY0k6/aSc6Frl5FEjxNO6yTA2ykoCPDcPCs DJsY5a4Ak8ElSdThrLmGBMzOdjxjwp6uWow4AkCVasX+7fODkWRDrCdY34hANT+jxg6w Xm/0c+qm4Mpsk6qRDTDLyRBIeQkJRzcd/wWkbYyAZBGMG6yu2VrPbbifrnMhHMUqNPFe ccZllUOj+wOEPavMj1iOeQ8wCQu7I5hASiq5B+lF/x/beS9/FRRBN3navGM/2jlNVDp6 X3A0pSTiBXL7i+e7nJ0acsAu1Yxm2mxb/1BdpD+wW6xiE8CJ5hwiPXxcqPqwxyU7sOiB z7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=72ITZJBpbIG9VsQo2cUy5Im243aqBGys0mIv1iVxo/w=; b=ce626a7L3o2ittI5Q4uV7iwZHAFu8aF+YV3Mnp+EgFmyeTxf3cCflDxRm31AezFDu8 117YxRbvoj7axCxO/LhDP50i0B36vadnAAleaCzNhaXWyrVcpr8sOhuEO5HDl+HOz4v1 NzThmpBZubpWdaZXFWoDcpA6CLCaanR4pxlOf9p5XHuBr7Q9XXBl84qwfhDgcumIWOaF dxmMzd5d7hGzLatev1+TeaoyLh9nEYcomi2emlsGAQvxm8dVb9Mg8FodRWd+ChlW/F27 Mw9Asdqhe7vfL/dPrdzh49g1JEod7Ejzp50vIjX5d6iy1UIUQEsv9Tu9ycEPw5L6xXsW PQ2g== X-Gm-Message-State: AOAM532EE+1zx5WPsUKxwPcpxFzu5+BWWTuS26PsxoyWWTzyU+l8lI19 w2CP2CKLi99Dv0vXzb9NDKo09gR0g+ia9EXtsEXKBcbzlPC32g== X-Google-Smtp-Source: ABdhPJz/ZiuKj81HSsFFy1IjysYud+SmR/fUeSx8iL7UcKhneYcIUGVYbG+LpxBQq3ZNP6rkMQ9g8XT/D9vT9+2IUPA= X-Received: by 2002:a05:6e02:1b0c:: with SMTP id i12mr4751137ilv.27.1632420921606; Thu, 23 Sep 2021 11:15:21 -0700 (PDT) MIME-Version: 1.0 References: <20210923135454.2967198-1-robert.marko@sartura.hr> In-Reply-To: From: Robert Marko Date: Thu, 23 Sep 2021 20:15:10 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: marvell: add Globalscale MOCHAbin To: Andrew Lunn Cc: Rob Herring , gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 23, 2021 at 7:32 PM Andrew Lunn wrote: > > > + /* 88E6141 Topaz switch */ > > + switch: switch@3 { > > + compatible = "marvell,mv88e6085"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <3>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&cp0_switch_pins>; > > + reset-gpios = <&cp0_gpio1 0 GPIO_ACTIVE_LOW>; > > + > > + interrupt-parent = <&cp0_gpio1>; > > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > > The switch interrupt is a level interrupt, not an edge interrupt. Hi Andrew, thanks for catching this. The same is true for the PCA9554 as well. Will fix that now in v3. Regards, Robert > > Andrew -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr