From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC941C4707F for ; Tue, 25 May 2021 09:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD48661413 for ; Tue, 25 May 2021 09:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232632AbhEYJf5 (ORCPT ); Tue, 25 May 2021 05:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbhEYJfz (ORCPT ); Tue, 25 May 2021 05:35:55 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 548E1C061574 for ; Tue, 25 May 2021 02:34:26 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id a6so3610054ioe.0 for ; Tue, 25 May 2021 02:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rGVIBQfA9yaEYKQ7c9uj55/JXYlST++Dmh1T8Dha/l4=; b=I2+wijtYwBgrvry710jQZ3rP7NQ43az4kzhNkjPiJtNH5xP3fgAtsU9gkUf/9lZVim T3NdpcCP/qy3TOExlpqJ3o3n+Bv1N7F9t53nA+i1h1yFSp3TygMjkqbKup7iDp1MOEgo PMSt1hdxuxcDeqpemy2893wnKsVcYneU6P23QZ3oFlWPhMfDoa9K/dOkmb19mswDH3gy PzHoF2cbOq9Xbt2bqgQLNHO9gAjpWkEYF+iofGOsRGz26XSkfV4gO/5PsRchya/TOA1H ATtPWlmaDpftSklsn23JmxRNytssrPNjc5QUHiBfZPMi5b7QwqtTBCtDUGS/Y1pbvRj7 aMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rGVIBQfA9yaEYKQ7c9uj55/JXYlST++Dmh1T8Dha/l4=; b=G6gigfhclQmV8Sbh1nU3jYN9vXTK0Z6KPzEHPKiL+hhGIcINlxQCgBA1n/oCVrlsGe /WOdmi2Gefignv8bbcdHSAoO48zOmntPtwNPfNce/hidWUkayk+B5KqqPKLY0Tl7v6dq Uh8x2BLl7fDcthBRPYdJyKPqxVnIXeWjWV8FpCpYyCgKUe8lxDfxGdxqSuhXtKHiMEHu +HzRuUq5SFBqiZAUt0wbsHEGts4wCaHXi2p0+eYv69JMhmqMD6+H+CC96oYXHStKqAPL IngS6QJLNZ//TDm6ejdbqGAL02fCiLf+vK1t2WCSfYii4UnG1KUk7m2EzJf9qc4vGHwa PXNg== X-Gm-Message-State: AOAM531do3SDt0TuNu5ZxgmwnRx8RozVbg/M7PMpDzINVaKlu2H7fxYQ tctzgjO65fGgIdqggptvIM/k5hQoJhdR/6+9y87t+A== X-Google-Smtp-Source: ABdhPJyhRwetuxqbSSb5e6pvmDFrqJrDw22vGXVFUtswYnw4/EGcGoFbgXDTHMhwKHDFkyJYEp/drlpV/oEUvD+QBDQ= X-Received: by 2002:a05:6602:189:: with SMTP id m9mr19947698ioo.88.1621935265730; Tue, 25 May 2021 02:34:25 -0700 (PDT) MIME-Version: 1.0 References: <20210524120539.3267145-1-robert.marko@sartura.hr> <20210524120539.3267145-3-robert.marko@sartura.hr> <20210524230940.GA1350504@robh.at.kernel.org> <20210525074649.GC4005783@dell> In-Reply-To: <20210525074649.GC4005783@dell> From: Robert Marko Date: Tue, 25 May 2021 11:34:15 +0200 Message-ID: Subject: Re: [PATCH v2 3/4] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings To: Lee Jones Cc: Rob Herring , Linus Walleij , bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luka Perkov , jmp@epiphyte.org, Paul Menzel , Donald Buczek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 9:46 AM Lee Jones wrote: > > On Mon, 24 May 2021, Rob Herring wrote: > > > On Mon, May 24, 2021 at 02:05:38PM +0200, Robert Marko wrote: > > > Add binding documents for the Delta TN48M CPLD drivers. > > > > > > Signed-off-by: Robert Marko > > > --- > > > Changes in v2: > > > * Implement MFD as a simple I2C MFD > > > * Add GPIO bindings as separate > > > > I don't understand why this changed. This doesn't look like an MFD to > > me. Make your binding complete if there are missing functions. > > Otherwise, stick with what I already ok'ed. > > Right. What else, besides GPIO, does this do? It currently does not do anything else as hwmon driver was essentially NACK-ed for not exposing standard attributes. The CPLD itself has PSU status-related information, bootstrap related information, various resets for the CPU-s, OOB ethernet PHY, information on the exact bo= ard model it's running etc. PSU and model-related info stuff is gonna be exposed via a misc driver in debugfs as we have user-space SW depending on that. I thought we agreed on that as v1 MFD driver was exposing those directly an= d not doing anything else. So I moved to use the simple I2C MFD driver, this is all modeled on the sl2= 8cpld which currently uses the same driver and then GPIO regmap as I do. Other stuff like the resets is probably gonna get exposed later when it's required to control it directly. Regards, Robert > > > > .../bindings/gpio/delta,tn48m-gpio.yaml | 42 ++++++++++ > > > .../bindings/mfd/delta,tn48m-cpld.yaml | 81 +++++++++++++++++= ++ > > > 2 files changed, 123 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/gpio/delta,tn48= m-gpio.yaml > > > create mode 100644 Documentation/devicetree/bindings/mfd/delta,tn48m= -cpld.yaml > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] > Senior Technical Lead - Developer Services > Linaro.org =E2=94=82 Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog --=20 Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr