From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDD2C4338F for ; Tue, 3 Aug 2021 19:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BA1A60F93 for ; Tue, 3 Aug 2021 19:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239869AbhHCTY2 (ORCPT ); Tue, 3 Aug 2021 15:24:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239802AbhHCTY0 (ORCPT ); Tue, 3 Aug 2021 15:24:26 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC58EC061764 for ; Tue, 3 Aug 2021 12:24:15 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id h18so20492951ilc.5 for ; Tue, 03 Aug 2021 12:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y/96BfjABv+2ZK/jpZFi0iu7CC65Hm3uVOTHPl3m7mc=; b=Ko8QTO3UZSL5npPAstJpoSRhMsNNBsd/m+RXr2vM4jmlvFN7qFCzS2Pel07CpVgoeX fwBBq7ddPVKUAPWN8a87MqRGb9P2/Z5aAKH1ENiY25Hn5M09EgDvChWoZ+USVGBrawS/ Aurnhygcg52ToqtSfIQtMLFg6HScrNQXM/33c0M01M+itkfov12rPTIg/b34qBXMBmub pvWAIUI8mQRFLtAGY3PSt4bdvqkYmBZFcQbSHioXvnXQUGxeSdMmNDj64L5n6UPopYef O3wwWReeV6RTCpGuPSuQHOA6sWKPNyoSmF8I9L+1nEsrKSHExR9zVAFTngqD41zI61c4 ZAqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y/96BfjABv+2ZK/jpZFi0iu7CC65Hm3uVOTHPl3m7mc=; b=UPL9rseKWDNCzekzbmKXSfowAWWX2ADbHJGb2VsEUjiQCbp2O+vvDb0Lwjern9CjwD lVyN5oKMyHOTukkgsVCt7XQdg5eQPwlyQIxjOzWt9px8QQeTT/IlVnpQmJC5A0XlHfdH DPXsAq6KlT0xPsjHhImeXKIu/5GG8P8xwJBuzljTaPOVzBPRTMatTGpdqNx+vDkNrSZB QdU6qkLz4w81cq0re3D63Nkwb/arT2FY0SQVl+8S6t3htEc3bikfi1cBKLq0A9MSHF6d 3D28dCGTvr+ZrBbc/ymENNKWbVqzLWMTQNO4lHx88i4MrVa/rtqB9ceYclGgNcjTvP7k 0ZcA== X-Gm-Message-State: AOAM5338TUtGhoXQD8HnIRiQBfo7QJp/vRXLZLXiJtXiz2BayDjuKsA2 qrLrx8j0hLMVbw4jvU8l5rMpRXOcmyBfDWnBZiPyQA== X-Google-Smtp-Source: ABdhPJyX1ZSfqH/AM+chZ4P6MWp2pVXcWeKNvN7A233YTlajJvq47+chl66UqJg64+jhJfxV2EFAZb7KkWOPXkqX60s= X-Received: by 2002:a05:6e02:5cf:: with SMTP id l15mr2268307ils.90.1628018655151; Tue, 03 Aug 2021 12:24:15 -0700 (PDT) MIME-Version: 1.0 References: <20210716221744.5445-1-robert.marko@sartura.hr> In-Reply-To: From: Robert Marko Date: Tue, 3 Aug 2021 21:24:04 +0200 Message-ID: Subject: Re: [PATCH 1/2] gpio: tn48m: Add support for Delta TN4810M CPLD To: Bartosz Golaszewski Cc: Linus Walleij , Rob Herring , linux-gpio , linux-devicetree , LKML , Luka Perkov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 2, 2021 at 2:12 PM Bartosz Golaszewski wrote: > > On Mon, Aug 2, 2021 at 2:10 PM Bartosz Golaszewski > wrote: > > > > On Sat, Jul 17, 2021 at 12:17 AM Robert Marko wrote: > > > > > > Delta TN4810M uses a similar CPLD GPIO expander > > > like the TN48M, but it has pins for 48 SFP+ ports, > > > making a total of 192 pins. > > > It also provides the TX fault pins which the TN48M > > > does not. > > > > > > Only TX disable pins like on the TN48M are output > > > ones. > > > > > > Thankfully, regmap GPIO allows for the driver to be > > > easily extended to support the TN4810M. > > > > > > Note that this patch depends on the following series: > > > https://patchwork.ozlabs.org/project/linux-gpio/list/?series=247538 > > > > > > Signed-off-by: Robert Marko > > > --- > > > drivers/gpio/gpio-tn48m.c | 56 ++++++++++++++++++++++++++++++++++++--- > > > 1 file changed, 52 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpio/gpio-tn48m.c b/drivers/gpio/gpio-tn48m.c > > > index b12a6b4bc4b3..e429e7ade941 100644 > > > --- a/drivers/gpio/gpio-tn48m.c > > > +++ b/drivers/gpio/gpio-tn48m.c > > > @@ -19,6 +19,10 @@ enum tn48m_gpio_type { > > > TN48M_SFP_TX_DISABLE = 1, > > > TN48M_SFP_PRESENT, > > > TN48M_SFP_LOS, > > > + TN4810M_SFP_TX_DISABLE, > > > + TN4810M_SFP_TX_FAULT, > > > + TN4810M_SFP_PRESENT, > > > + TN4810M_SFP_LOS, > > > }; > > > > > > static int tn48m_gpio_probe(struct platform_device *pdev) > > > @@ -46,17 +50,36 @@ static int tn48m_gpio_probe(struct platform_device *pdev) > > > > > > config.regmap = regmap; > > > config.parent = &pdev->dev; > > > - config.ngpio = 4; > > > + config.ngpio_per_reg = 8; > > > > > > switch (type) { > > > case TN48M_SFP_TX_DISABLE: > > > config.reg_set_base = base; > > > + config.ngpio = 4; > > > break; > > > case TN48M_SFP_PRESENT: > > > config.reg_dat_base = base; > > > + config.ngpio = 4; > > > break; > > > case TN48M_SFP_LOS: > > > config.reg_dat_base = base; > > > + config.ngpio = 4; > > > + break; > > > + case TN4810M_SFP_TX_DISABLE: > > > + config.reg_set_base = base; > > > + config.ngpio = 48; > > > + break; > > > + case TN4810M_SFP_TX_FAULT: > > > + config.reg_dat_base = base; > > > + config.ngpio = 48; > > > + break; > > > + case TN4810M_SFP_PRESENT: > > > + config.reg_dat_base = base; > > > + config.ngpio = 48; > > > + break; > > > + case TN4810M_SFP_LOS: > > > + config.reg_dat_base = base; > > > + config.ngpio = 48; > > > break; > > > default: > > > dev_err(&pdev->dev, "unknown type %d\n", type); > > > @@ -67,9 +90,34 @@ static int tn48m_gpio_probe(struct platform_device *pdev) > > > } > > > > > > static const struct of_device_id tn48m_gpio_of_match[] = { > > > - { .compatible = "delta,tn48m-gpio-sfp-tx-disable", .data = (void *)TN48M_SFP_TX_DISABLE }, > > > - { .compatible = "delta,tn48m-gpio-sfp-present", .data = (void *)TN48M_SFP_PRESENT }, > > > - { .compatible = "delta,tn48m-gpio-sfp-los", .data = (void *)TN48M_SFP_LOS }, > > > + { > > > + .compatible = "delta,tn48m-gpio-sfp-tx-disable", > > > + .data = (void *)TN48M_SFP_TX_DISABLE > > > + }, > > > + { > > > + .compatible = "delta,tn48m-gpio-sfp-present", > > > + .data = (void *)TN48M_SFP_PRESENT > > > + }, > > > + { > > > + .compatible = "delta,tn48m-gpio-sfp-los", > > > + .data = (void *)TN48M_SFP_LOS > > > + }, > > > + { > > > + .compatible = "delta,tn4810m-gpio-sfp-tx-disable", > > > + .data = (void *)TN4810M_SFP_TX_DISABLE > > > + }, > > > + { > > > + .compatible = "delta,tn4810m-gpio-sfp-tx-fault", > > > + .data = (void *)TN4810M_SFP_TX_FAULT > > > + }, > > > + { > > > + .compatible = "delta,tn4810m-gpio-sfp-present", > > > + .data = (void *)TN4810M_SFP_PRESENT > > > + }, > > > + { > > > + .compatible = "delta,tn4810m-gpio-sfp-los", > > > + .data = (void *)TN4810M_SFP_LOS > > > + }, > > > { } > > > }; > > > MODULE_DEVICE_TABLE(of, tn48m_gpio_of_match); > > > -- > > > 2.31.1 > > > > > > > This looks good to me. I suppose the other patches are going in > > through the MFD tree. I don't see anything that can fail here at > > build-time - can you confirm that I can pick these patches up > > separately for v5.15? > > > > Bartosz > > Scratch that, I now saw Linus' comment about the special purpose pins > under the other series. Let's clear that up first. Yeah, I have finally replied to Linus, hopefully, we can clear it up. Thanks, Robert > > Bart -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr