From: Tomasz Figa <tomasz.figa@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"moderated list:SAMSUNG SOC CLOCK DRIVERS"
<linux-samsung-soc@vger.kernel.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: Use of_node_name_eq for node name comparisons
Date: Wed, 5 Dec 2018 21:25:17 -0800 [thread overview]
Message-ID: <CA+Ln22Gj=1PovdRT9HCun4vkZmHfGh2t6ouOTrFqSZHiNvK1Zw@mail.gmail.com> (raw)
In-Reply-To: <20181205195050.4759-20-robh@kernel.org>
2018年12月5日(水) 11:51 Rob Herring <robh@kernel.org>:
>
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index ee6ee2338606..de0477bb469d 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
> continue;
> bank = d->pin_banks;
> for (i = 0; i < d->nr_banks; ++i, ++bank) {
> - if (!strcmp(bank->name, np->name)) {
> + if (of_node_name_eq(np, bank->name)) {
> bank->of_node = np;
> break;
> }
> --
> 2.19.1
>
Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2018-12-06 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:50 [PATCH] pinctrl: Use of_node_name_eq for node name comparisons Rob Herring
2018-12-06 5:25 ` Tomasz Figa [this message]
2018-12-06 7:07 ` Krzysztof Kozlowski
2018-12-14 15:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Ln22Gj=1PovdRT9HCun4vkZmHfGh2t6ouOTrFqSZHiNvK1Zw@mail.gmail.com' \
--to=tomasz.figa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).