From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933447AbcLIMkU (ORCPT ); Fri, 9 Dec 2016 07:40:20 -0500 Received: from mail-qk0-f181.google.com ([209.85.220.181]:34751 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933048AbcLIMkR (ORCPT ); Fri, 9 Dec 2016 07:40:17 -0500 MIME-Version: 1.0 In-Reply-To: <20161209085331.GB3625@dell.home> References: <1481199650-22484-1-git-send-email-benjamin.gaignard@st.com> <1481199650-22484-2-git-send-email-benjamin.gaignard@st.com> <20161209085331.GB3625@dell.home> From: Benjamin Gaignard Date: Fri, 9 Dec 2016 13:40:16 +0100 Message-ID: Subject: Re: [PATCH v5 1/7] MFD: add bindings for STM32 General Purpose Timer driver To: Lee Jones Cc: robh+dt@kernel.org, Mark Rutland , alexandre.torgue@st.com, devicetree@vger.kernel.org, Linux Kernel Mailing List , Thierry Reding , linux-pwm@vger.kernel.org, Jonathan Cameron , knaack.h@gmx.de, Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabrice Gasnier , Gerald Baeza , Arnaud Pouliquen , Linus Walleij , Linaro Kernel Mailman List , Benjamin Gaignard Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB9CeQnY012106 2016-12-09 9:53 GMT+01:00 Lee Jones : > Sorry to do this Ben. Not much to do now though! > >> Add bindings information for STM32 General Purpose Timer >> >> version 2: >> - rename stm32-mfd-timer to stm32-gptimer >> - only keep one compatible string >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../bindings/mfd/stm32-general-purpose-timer.txt | 39 ++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt >> new file mode 100644 >> index 0000000..ce67755 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/stm32-general-purpose-timer.txt >> @@ -0,0 +1,39 @@ >> +STM32 General Purpose Timer driver bindings > > This is a great place to describe what we're *actually* trying to > achieve with this driver, and the worst place to use the term "general > purpose", since this IP is so much more than that. > > > "STM32 Timers > > This IP provides 3 types of timer along with PWM functionality. > > [...]" > > ... then go on to explain what the 3 types are and how they can be > used. > >> +Required parameters: >> +- compatible: must be "st,stm32-gptimer" > > I vehemently disagree that this entire IP is a GP Timer. It contains > GP timers, sure, but it also contains Advanced and Basic timers. > > IMHO this compatible should be "st,stm32-timers". > > And the file name of both this and the *.c file should reflect that > too. I will do those name changes in v6. > > Remainder looks nice. > >> +- reg: Physical base address and length of the controller's >> + registers. >> +- clock-names: Set to "clk_int". >> +- clocks: Phandle to the clock used by the timer module. >> + For Clk properties, please refer to ../clock/clock-bindings.txt >> + >> +Optional parameters: >> +- resets: Phandle to the parent reset controller. >> + See ../reset/st,stm32-rcc.txt >> + >> +Optional subnodes: >> +- pwm: See ../pwm/pwm-stm32.txt >> +- timer: See ../iio/timer/stm32-timer-trigger.txt >> + >> +Example: >> + timers@40010000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "st,stm32-gptimer"; >> + reg = <0x40010000 0x400>; >> + clocks = <&rcc 0 160>; >> + clock-names = "clk_int"; >> + >> + pwm@0 { > > Out of interest, do you use the "@0", "@1" for anything now? No I don't use them so I will remove them in v6 > >> + compatible = "st,stm32-pwm"; >> + pinctrl-0 = <&pwm1_pins>; >> + pinctrl-names = "default"; >> + }; >> + >> + timer@0 { >> + compatible = "st,stm32-timer-trigger"; >> + reg = <0>; >> + }; >> + }; > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog