linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] drm/sti: remove set but not used variable 'priv'
@ 2018-11-10  2:57 YueHaibing
  2018-11-13 11:09 ` Benjamin Gaignard
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-10  2:57 UTC (permalink / raw)
  To: Benjamin Gaignard, Vincent Abriou, David Airlie
  Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/sti/sti_crtc.c: In function 'sti_crtc_vblank_cb':
drivers/gpu/drm/sti/sti_crtc.c:255:22: warning:
 variable 'priv' set but not used [-Wunused-but-set-variable]

It never used since introduction in
  9e1f05b28009 ("drm/sti: rename files and functions")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/sti/sti_crtc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
index 61c2379..ed76e52e 100644
--- a/drivers/gpu/drm/sti/sti_crtc.c
+++ b/drivers/gpu/drm/sti/sti_crtc.c
@@ -252,10 +252,8 @@ int sti_crtc_vblank_cb(struct notifier_block *nb,
 	struct sti_compositor *compo;
 	struct drm_crtc *crtc = data;
 	struct sti_mixer *mixer;
-	struct sti_private *priv;
 	unsigned int pipe;
 
-	priv = crtc->dev->dev_private;
 	pipe = drm_crtc_index(crtc);
 	compo = container_of(nb, struct sti_compositor, vtg_vblank_nb[pipe]);
 	mixer = compo->mixer[pipe];




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] drm/sti: remove set but not used variable 'priv'
  2018-11-10  2:57 [PATCH -next] drm/sti: remove set but not used variable 'priv' YueHaibing
@ 2018-11-13 11:09 ` Benjamin Gaignard
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Gaignard @ 2018-11-13 11:09 UTC (permalink / raw)
  To: yuehaibing
  Cc: Vincent Abriou, David Airlie, ML dri-devel,
	Linux Kernel Mailing List, kernel-janitors

Le sam. 10 nov. 2018 à 03:48, YueHaibing <yuehaibing@huawei.com> a écrit :
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/sti/sti_crtc.c: In function 'sti_crtc_vblank_cb':
> drivers/gpu/drm/sti/sti_crtc.c:255:22: warning:
>  variable 'priv' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
>   9e1f05b28009 ("drm/sti: rename files and functions")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied on drm-misc-next.

Thanks,
Benjamin

> ---
>  drivers/gpu/drm/sti/sti_crtc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index 61c2379..ed76e52e 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -252,10 +252,8 @@ int sti_crtc_vblank_cb(struct notifier_block *nb,
>         struct sti_compositor *compo;
>         struct drm_crtc *crtc = data;
>         struct sti_mixer *mixer;
> -       struct sti_private *priv;
>         unsigned int pipe;
>
> -       priv = crtc->dev->dev_private;
>         pipe = drm_crtc_index(crtc);
>         compo = container_of(nb, struct sti_compositor, vtg_vblank_nb[pipe]);
>         mixer = compo->mixer[pipe];
>
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-13 11:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-10  2:57 [PATCH -next] drm/sti: remove set but not used variable 'priv' YueHaibing
2018-11-13 11:09 ` Benjamin Gaignard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).