linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Yannick Fertre <yannick.fertre@st.com>
Cc: Philippe Cornu <philippe.cornu@st.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/stm: ltdc: rework reset sequence
Date: Fri, 6 Jul 2018 10:22:43 +0200	[thread overview]
Message-ID: <CA+M3ks5GNf6i_mFqFEganGJ7-3nY+OxGwxzX1UYbT1dkv8WtMg@mail.gmail.com> (raw)
In-Reply-To: <1530271355-5608-1-git-send-email-yannick.fertre@st.com>

2018-06-29 13:22 GMT+02:00 Yannick Fertre <yannick.fertre@st.com>:
> Reset must be properly assert before deassert.
> This is important if there is an early boot splash screen
> before the kernel start up.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>

Applied on drm-misc-next.
Thansk,
Benjamin

> ---
>  drivers/gpu/drm/stm/ltdc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 96d20c2..8f4606d 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev)
>                 }
>         }
>
> -       if (!IS_ERR(rstc))
> +       if (!IS_ERR(rstc)) {
> +               reset_control_assert(rstc);
> +               usleep_range(10, 20);
>                 reset_control_deassert(rstc);
> +       }
>
>         /* Disable interrupts */
>         reg_clear(ldev->regs, LTDC_IER,
> --
> 1.9.1
>

      parent reply	other threads:[~2018-07-06  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 11:22 [PATCH] drm/stm: ltdc: rework reset sequence Yannick Fertre
2018-07-03 11:02 ` Philippe CORNU
2018-07-06  8:22 ` Benjamin Gaignard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+M3ks5GNf6i_mFqFEganGJ7-3nY+OxGwxzX1UYbT1dkv8WtMg@mail.gmail.com \
    --to=benjamin.gaignard@linaro.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philippe.cornu@st.com \
    --cc=vincent.abriou@st.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).