linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board
@ 2019-08-02 14:08 Yannick Fertré
  2019-09-02  8:45 ` Philippe CORNU
  2019-10-03 10:05 ` Alexandre Torgue
  0 siblings, 2 replies; 4+ messages in thread
From: Yannick Fertré @ 2019-08-02 14:08 UTC (permalink / raw)
  To: Maxime Coquelin, Alexandre Torgue, Rob Herring, Mark Rutland,
	linux-stm32, linux-arm-kernel, devicetree, linux-kernel,
	Benjamin Gaignard, Yannick Fertre, Philippe Cornu,
	Fabrice Gasnier

The ltdc pinctrl must be in the display controller node and
not in the peripheral node (hdmi bridge).

Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
---
 arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
index f3f0e37..1285cfc 100644
--- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
+++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
@@ -99,9 +99,6 @@
 		reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
 		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-parent = <&gpiog>;
-		pinctrl-names = "default", "sleep";
-		pinctrl-0 = <&ltdc_pins_a>;
-		pinctrl-1 = <&ltdc_pins_sleep_a>;
 		status = "okay";
 
 		ports {
@@ -276,6 +273,9 @@
 };
 
 &ltdc {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&ltdc_pins_a>;
+	pinctrl-1 = <&ltdc_pins_sleep_a>;
 	status = "okay";
 
 	port {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board
  2019-08-02 14:08 [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board Yannick Fertré
@ 2019-09-02  8:45 ` Philippe CORNU
  2019-09-02  9:35   ` Benjamin Gaignard
  2019-10-03 10:05 ` Alexandre Torgue
  1 sibling, 1 reply; 4+ messages in thread
From: Philippe CORNU @ 2019-09-02  8:45 UTC (permalink / raw)
  To: Yannick FERTRE, Maxime Coquelin, Alexandre TORGUE, Rob Herring,
	Mark Rutland, linux-stm32, linux-arm-kernel, devicetree,
	linux-kernel, Benjamin GAIGNARD, Fabrice GASNIER

Hi Yannick,

On 8/2/19 4:08 PM, Yannick Fertré wrote:
> The ltdc pinctrl must be in the display controller node and
> not in the peripheral node (hdmi bridge).
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
>   arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index f3f0e37..1285cfc 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -99,9 +99,6 @@
>   		reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
>   		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>   		interrupt-parent = <&gpiog>;
> -		pinctrl-names = "default", "sleep";
> -		pinctrl-0 = <&ltdc_pins_a>;
> -		pinctrl-1 = <&ltdc_pins_sleep_a>;
>   		status = "okay";
>   
>   		ports {
> @@ -276,6 +273,9 @@
>   };
>   
>   &ltdc {
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&ltdc_pins_a>;
> +	pinctrl-1 = <&ltdc_pins_sleep_a>;

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>

Thanks
Philippe :)

>   	status = "okay";
>   
>   	port {
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board
  2019-09-02  8:45 ` Philippe CORNU
@ 2019-09-02  9:35   ` Benjamin Gaignard
  0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Gaignard @ 2019-09-02  9:35 UTC (permalink / raw)
  To: Philippe CORNU
  Cc: Yannick FERTRE, Maxime Coquelin, Alexandre TORGUE, Rob Herring,
	Mark Rutland, linux-stm32, linux-arm-kernel, devicetree,
	linux-kernel, Benjamin GAIGNARD, Fabrice GASNIER

+ dri-devel mailing list

Le lun. 2 sept. 2019 à 10:45, Philippe CORNU <philippe.cornu@st.com> a écrit :
>
> Hi Yannick,
>
> On 8/2/19 4:08 PM, Yannick Fertré wrote:
> > The ltdc pinctrl must be in the display controller node and
> > not in the peripheral node (hdmi bridge).
> >
> > Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> > ---
> >   arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > index f3f0e37..1285cfc 100644
> > --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > @@ -99,9 +99,6 @@
> >               reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
> >               interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> >               interrupt-parent = <&gpiog>;
> > -             pinctrl-names = "default", "sleep";
> > -             pinctrl-0 = <&ltdc_pins_a>;
> > -             pinctrl-1 = <&ltdc_pins_sleep_a>;
> >               status = "okay";
> >
> >               ports {
> > @@ -276,6 +273,9 @@
> >   };
> >
> >   &ltdc {
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&ltdc_pins_a>;
> > +     pinctrl-1 = <&ltdc_pins_sleep_a>;
>
> Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
>
> Thanks
> Philippe :)
>
> >       status = "okay";
> >
> >       port {
> >
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board
  2019-08-02 14:08 [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board Yannick Fertré
  2019-09-02  8:45 ` Philippe CORNU
@ 2019-10-03 10:05 ` Alexandre Torgue
  1 sibling, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2019-10-03 10:05 UTC (permalink / raw)
  To: Yannick Fertré,
	Maxime Coquelin, Rob Herring, Mark Rutland, linux-stm32,
	linux-arm-kernel, devicetree, linux-kernel, Benjamin Gaignard,
	Philippe Cornu, Fabrice Gasnier

Hi Yannick

On 8/2/19 4:08 PM, Yannick Fertré wrote:
> The ltdc pinctrl must be in the display controller node and
> not in the peripheral node (hdmi bridge).
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
>   arch/arm/boot/dts/stm32mp157a-dk1.dts | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index f3f0e37..1285cfc 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -99,9 +99,6 @@
>   		reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
>   		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>   		interrupt-parent = <&gpiog>;
> -		pinctrl-names = "default", "sleep";
> -		pinctrl-0 = <&ltdc_pins_a>;
> -		pinctrl-1 = <&ltdc_pins_sleep_a>;
>   		status = "okay";
>   
>   		ports {
> @@ -276,6 +273,9 @@
>   };
>   
>   &ltdc {
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&ltdc_pins_a>;
> +	pinctrl-1 = <&ltdc_pins_sleep_a>;
>   	status = "okay";
>   
>   	port {
> 

Applied on stm32-next.

Thanks.
Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-03 10:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 14:08 [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board Yannick Fertré
2019-09-02  8:45 ` Philippe CORNU
2019-09-02  9:35   ` Benjamin Gaignard
2019-10-03 10:05 ` Alexandre Torgue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).