From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-media@vger.kernel.org, linux-spi@vger.kernel.org,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
alsa-devel@alsa-project.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs
Date: Mon, 15 Oct 2018 11:12:55 +0200 [thread overview]
Message-ID: <CA+M3ks5KO-Yr_PEczaENhTfirthFz2gW1uv4bwZe5mjy3-jZyg@mail.gmail.com> (raw)
In-Reply-To: <20181013151707.32210-8-hch@lst.de>
Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit :
>
> The DMA API does its own zone decisions based on the coherent_dma_mask.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> ---
> drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c
> index 26d9fa7aeb5f..4372abbb5950 100644
> --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c
> +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c
> @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev)
>
> /* Allocate all the filters within a single memory page */
> size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER);
> - base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA,
> + base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL,
> DMA_ATTR_WRITE_COMBINE);
> if (!base)
> return -ENOMEM;
> --
> 2.19.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Benjamin Gaignard
Graphic Study Group
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-10-15 9:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 15:16 remove bogus GFP_DMA32 flags for dma allocations Christoph Hellwig
2018-10-13 15:17 ` [PATCH 1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-15 7:43 ` Rafael J. Wysocki
2018-10-17 7:19 ` Christoph Hellwig
2018-10-17 7:22 ` Rafael J. Wysocki
2018-10-13 15:17 ` [PATCH 2/8] firmware: tegra: " Christoph Hellwig
2018-10-13 15:17 ` [PATCH 3/8] spi: pic32-sqi: " Christoph Hellwig
2018-10-17 11:55 ` Applied "spi: pic32-sqi: don't pass GFP_DMA32 to dma_alloc_coherent" to the spi tree Mark Brown
2018-10-13 15:17 ` [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-13 16:18 ` [alsa-devel] " Takashi Iwai
2018-10-13 16:35 ` Christoph Hellwig
2018-10-13 18:10 ` Takashi Iwai
2018-10-13 15:17 ` [PATCH 5/8] sound: intel/sst: " Christoph Hellwig
2018-10-13 16:20 ` [alsa-devel] " Takashi Iwai
2018-10-17 11:54 ` Applied "ASoC: intel: don't pass GFP_DMA32 to dma_alloc_coherent" to the asoc tree Mark Brown
2018-10-13 15:17 ` [PATCH 6/8] drm: sti: don't pass GFP_DMA32 to dma_alloc_wc Christoph Hellwig
2018-10-15 9:12 ` Benjamin Gaignard
2018-10-16 12:41 ` Benjamin Gaignard
2018-10-17 7:19 ` Christoph Hellwig
2018-10-18 11:59 ` Benjamin Gaignard
2018-10-13 15:17 ` [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Christoph Hellwig
2018-10-15 9:12 ` Benjamin Gaignard [this message]
2018-10-17 7:20 ` Christoph Hellwig
2018-10-18 12:00 ` Benjamin Gaignard
2018-12-05 10:31 ` Mauro Carvalho Chehab
2018-10-13 15:17 ` [PATCH 8/8] fsl-diu-fb: don't pass GFP_DMA32 to dmam_alloc_coherent Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+M3ks5KO-Yr_PEczaENhTfirthFz2gW1uv4bwZe5mjy3-jZyg@mail.gmail.com \
--to=benjamin.gaignard@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).