From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755517AbcJZOlj (ORCPT ); Wed, 26 Oct 2016 10:41:39 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:38137 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754100AbcJZOlg (ORCPT ); Wed, 26 Oct 2016 10:41:36 -0400 MIME-Version: 1.0 In-Reply-To: References: <1477488748-10065-1-git-send-email-benjamin.gaignard@linaro.org> From: Benjamin Gaignard Date: Wed, 26 Oct 2016 16:41:35 +0200 Message-ID: Subject: Re: [PATCH 0/3] add ION driver for STIh4xx SoC To: Sumit Semwal Cc: Laura Abbott , Greg Kroah-Hartman , yudongbin@hisilicon.com, Chen Feng , LKML , "linaro-kernel@lists.linaro.org" , kernel@stlinux.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9QEfhH5000878 2016-10-26 15:51 GMT+02:00 Sumit Semwal : > Hello Benjamin, > > On 26 October 2016 at 19:02, Benjamin Gaignard > wrote: >> It is more or less a copy of Hisilicon driver but with a heap definition >> fitting with STIH4xx SoC needs. >> I have just chnage the some function prefix from "hi6220" to "sti". >> > Thanks for your patches! > > I was just wondering if you couldn't convert the HiSilicon driver into > something like a 'simple-ion' driver, and have just the DT definitions > as specifics? This would save a lot of code duplication, and keep it > as a simple interface for common heaps like cma. Create a simple-ion driver is a good idea but it means that heaps (configuration, name, etc..) will have to be describe into devicetree. I'm not sure if that will is acceptable. > > If there are any ST-specific requirements that are incompatible with > the existing driver, it should be clearly documented out here I think. heaps names and Ids aren't the same so I can't reuse hisilicon driver. -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog