From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbdKGN5c (ORCPT ); Tue, 7 Nov 2017 08:57:32 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:53598 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbdKGN5b (ORCPT ); Tue, 7 Nov 2017 08:57:31 -0500 X-Google-Smtp-Source: ABhQp+TKI+oFBp+PVgMQ1/CYRqLPJlcezcR00Zfqz9ezV4i/lWxeQJh/t9M0B9mNN3ePHsT28JJz+R9NcfYYg+KRp+4= MIME-Version: 1.0 In-Reply-To: <20171101113301.GD4111@jade> References: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> <20171101113301.GD4111@jade> From: Benjamin Gaignard Date: Tue, 7 Nov 2017 14:57:30 +0100 Message-ID: Subject: Re: [PATCH] drm/stm: checkpatch strict minor updates To: Gustavo Padovan Cc: Philippe Cornu , Yannick Fertre , Vincent Abriou , David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Alexandre Torgue , Fabien Dessenne , Maxime Coquelin , Mickael Reulier , Gabriel Fernandez , Ludovic Barre Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-11-01 12:33 GMT+01:00 Gustavo Padovan : > 2017-10-26 Philippe Cornu : > >> Minor fixes detected with "scripts/checkpatch.pl --strict" >> >> Signed-off-by: Philippe Cornu >> --- >> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- >> drivers/gpu/drm/stm/ltdc.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> index 10b2b77..3e8b9ed 100644 >> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> @@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz, >> int fvco_min, fvco_max, delta, best_delta; /* all in khz */ >> >> /* Early checks preventing division by 0 & odd results */ >> - if ((clkin_khz <= 0) || (clkout_khz <= 0)) >> + if (clkin_khz <= 0 || clkout_khz <= 0) >> return -EINVAL; >> >> fvco_min = LANE_MIN_KBPS * 2 * ODF_MAX; >> @@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz, >> for (o = ODF_MIN; o <= ODF_MAX; o *= 2) { >> n = DIV_ROUND_CLOSEST(i * o * clkout_khz, clkin_khz); >> /* Check ndiv according to vco range */ >> - if ((n < n_min) || (n > n_max)) >> + if (n < n_min || n > n_max) >> continue; >> /* Check if new delta is better & saves parameters */ >> delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) - >> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c >> index 735c908..7be6710 100644 >> --- a/drivers/gpu/drm/stm/ltdc.c >> +++ b/drivers/gpu/drm/stm/ltdc.c >> @@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane, >> src_h = state->src_h >> 16; >> >> /* Reject scaling */ >> - if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) { >> + if (src_w != state->crtc_w || src_h != state->crtc_h) { >> DRM_ERROR("Scaling is not supported"); >> return -EINVAL; > > Reviewed-by: Gustavo Padovan > Applied on drm-misc-next. Thanks Benjamin