From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbcK0Ppp (ORCPT ); Sun, 27 Nov 2016 10:45:45 -0500 Received: from mail-qt0-f169.google.com ([209.85.216.169]:35900 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcK0Ppg (ORCPT ); Sun, 27 Nov 2016 10:45:36 -0500 MIME-Version: 1.0 In-Reply-To: References: <1480000463-9625-1-git-send-email-benjamin.gaignard@st.com> <1480000463-9625-6-git-send-email-benjamin.gaignard@st.com> From: Benjamin Gaignard Date: Sun, 27 Nov 2016 16:45:34 +0100 Message-ID: Subject: Re: [PATCH v2 5/7] IIO: add bindings for stm32 IIO timer driver To: Jonathan Cameron Cc: Lee Jones , robh+dt@kernel.org, Mark Rutland , alexandre.torgue@st.com, devicetree@vger.kernel.org, Linux Kernel Mailing List , Thierry Reding , linux-pwm@vger.kernel.org, knaack.h@gmx.de, Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabrice Gasnier , Gerald Baeza , Arnaud Pouliquen , Linus Walleij , Linaro Kernel Mailman List , Benjamin Gaignard Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-11-27 15:25 GMT+01:00 Jonathan Cameron : > On 24/11/16 15:14, Benjamin Gaignard wrote: >> Define bindings for stm32 IIO timer >> >> version 2: >> - only keep one compatible >> - add DT parameters to set lists of the triggers: >> one list describe the triggers created by the device >> another one give the triggers accepted by the device >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../bindings/iio/timer/stm32-iio-timer.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-iio-timer.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-iio-timer.txt b/Documentation/devicetree/bindings/iio/timer/stm32-iio-timer.txt >> new file mode 100644 >> index 0000000..840b417 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/timer/stm32-iio-timer.txt >> @@ -0,0 +1,41 @@ >> +timer IIO trigger bindings for STM32 >> + >> +Must be a sub-node of STM32 general purpose timer driver > Add a cross reference... I will add it in v3 >> + >> +Required parameters: >> +- compatible: must be "st,stm32-iio-timer" > st,stm32-adc-timer or something like that. I would prefer use st,stm32-timer-trigger because triggers can be used for multiple other devices (dac, adc, timers) >> +- interrupts: Interrupt for this device >> + See ../interrupt-controller/st,stm32-exti.txt >> + >> +Optional parameters: >> +- st,input-triggers-names: List of the possible input triggers for >> + the device >> +- st,output-triggers-names: List of the possible output triggers for >> + the device > What are input / output triggers? each hardware block can be the source of triggers (output triggers) or customer of some other trigger (input triggers).That what I have tried to describe in those two parameters >> + >> +Possible triggers are defined in include/dt-bindings/iio/timer/st,stm32-iio-timer.h >> + >> +Example: >> + gptimer1: gptimer1@40010000 { >> + compatible = "st,stm32-gptimer"; >> + reg = <0x40010000 0x400>; >> + clocks = <&rcc 0 160>; >> + clock-names = "clk_int"; >> + >> + pwm1@0 { >> + compatible = "st,stm32-pwm"; >> + st,pwm-num-chan = <4>; >> + st,breakinput; >> + st,complementary; >> + }; >> + >> + iiotimer1@0 { >> + compatible = "st,stm32-iio-timer"; >> + interrupts = <27>; >> + st,input-triggers-names = TIM5_TRGO, >> + TIM2_TRGO, >> + TIM4_TRGO, >> + TIM3_TRGO; >> + st,output-triggers-names = TIM1_TRGO; >> + }; >> + }; >> >