From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xue.zhihong@zte.com.cn, wang.yi59@zte.com.cn,
"Hans Verkuil (hansverk)" <hansverk@cisco.com>,
Wen Yang <yellowriver2010@hotmail.com>
Subject: Re: [PATCH v2 4/4] media: platform: sti: fix possible object reference leak
Date: Wed, 13 Feb 2019 10:07:38 +0100 [thread overview]
Message-ID: <CA+M3ks7EO-Fy4KFEu5NgpsK73z2BsEhEsBZ8qraFoPnT7nTVLQ@mail.gmail.com> (raw)
In-Reply-To: <1550015329-42952-1-git-send-email-wen.yang99@zte.com.cn>
Le mer. 13 févr. 2019 à 00:49, Wen Yang <wen.yang99@zte.com.cn> a écrit :
>
> The call to of_parse_phandle() returns a node pointer with refcount
> incremented thus it must be explicitly decremented here after the last
> usage.
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we also should release that reference.
>
> Hans Verkuil says:
> The cec driver should never take a reference of the hdmi device.
> It never accesses the HDMI device, it only needs the HDMI device pointer as
> a key in the notifier list.
> The real problem is that several CEC drivers take a reference of the HDMI
> device and never release it. So those drivers need to be fixed.
>
> This patch fixes those two issues.
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>
> Fixes: fc4e009c6c98 ("[media] stih-cec: add CEC notifier support")
> Suggested-by: Hans Verkuil (hansverk) <hansverk@cisco.com>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Cc: Hans Verkuil (hansverk) <hansverk@cisco.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Wen Yang <yellowriver2010@hotmail.com>
> Cc: linux-media@vger.kernel.org
> ---
> v2->v1:
> - move of_node_put() to just after the 'hdmi_dev = of_find_device_by_node(np)'.
> - put_device() can be done before the cec = devm_kzalloc line.
>
> drivers/media/platform/sti/cec/stih-cec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/sti/cec/stih-cec.c b/drivers/media/platform/sti/cec/stih-cec.c
> index d34099f..721021f 100644
> --- a/drivers/media/platform/sti/cec/stih-cec.c
> +++ b/drivers/media/platform/sti/cec/stih-cec.c
> @@ -317,9 +317,11 @@ static int stih_cec_probe(struct platform_device *pdev)
> }
>
> hdmi_dev = of_find_device_by_node(np);
> + of_node_put(np);
> if (!hdmi_dev)
> return -EPROBE_DEFER;
>
> + put_device(&hdmi_dev->dev);
> cec->notifier = cec_notifier_get(&hdmi_dev->dev);
> if (!cec->notifier)
> return -ENOMEM;
> --
> 2.9.5
>
prev parent reply other threads:[~2019-02-13 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 23:48 [PATCH v2 4/4] media: platform: sti: fix possible object reference leak Wen Yang
2019-02-13 9:07 ` Benjamin Gaignard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+M3ks7EO-Fy4KFEu5NgpsK73z2BsEhEsBZ8qraFoPnT7nTVLQ@mail.gmail.com \
--to=benjamin.gaignard@linaro.org \
--cc=hansverk@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).