From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbcKGKSX (ORCPT ); Mon, 7 Nov 2016 05:18:23 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:35114 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbcKGKRq (ORCPT ); Mon, 7 Nov 2016 05:17:46 -0500 MIME-Version: 1.0 In-Reply-To: References: <1477488748-10065-1-git-send-email-benjamin.gaignard@linaro.org> From: Benjamin Gaignard Date: Mon, 7 Nov 2016 11:17:45 +0100 Message-ID: Subject: Re: [PATCH 0/3] add ION driver for STIh4xx SoC To: Laura Abbott Cc: Sumit Semwal , Greg Kroah-Hartman , yudongbin@hisilicon.com, Chen Feng , LKML , "linaro-kernel@lists.linaro.org" , kernel@stlinux.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA7AIQU2030373 Hello Laura, What are plumbers outputs for ION after your talk ? Regards, Benjamin 2016-10-27 1:25 GMT+02:00 Laura Abbott : > On 10/26/2016 08:05 AM, Benjamin Gaignard wrote: >> >> 2016-10-26 16:44 GMT+02:00 Sumit Semwal : >>> >>> On 26 October 2016 at 20:11, Benjamin Gaignard >>> wrote: >>>> >>>> 2016-10-26 15:51 GMT+02:00 Sumit Semwal : >>>>> >>>>> Hello Benjamin, >>>>> >>>>> On 26 October 2016 at 19:02, Benjamin Gaignard >>>>> wrote: >>>>>> >>>>>> It is more or less a copy of Hisilicon driver but with a heap >>>>>> definition >>>>>> fitting with STIH4xx SoC needs. >>>>>> I have just chnage the some function prefix from "hi6220" to "sti". >>>>>> >>>>> Thanks for your patches! >>>>> >>>>> I was just wondering if you couldn't convert the HiSilicon driver into >>>>> something like a 'simple-ion' driver, and have just the DT definitions >>>>> as specifics? This would save a lot of code duplication, and keep it >>>>> as a simple interface for common heaps like cma. >>>> >>>> >>>> Create a simple-ion driver is a good idea but it means that heaps >>>> (configuration, name, etc..) >>>> will have to be describe into devicetree. I'm not sure if that will is >>>> acceptable. >>>> >>>>> >>>>> If there are any ST-specific requirements that are incompatible with >>>>> the existing driver, it should be clearly documented out here I think. >>>> >>>> >>>> heaps names and Ids aren't the same so I can't reuse hisilicon driver. >>>> >>> But I'd suspect both these are solvable with using something like >>> 'generic,cma' instead of 'hisi,cma' or 'st,cma'? >> >> >> yes, but it requires to describe the heaps in devicetree. >> Hisilicon driver was doing like that until last month but Laura >> convert it to common platform: >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/staging/android/ion/hisilicon?id=b6e336dbeda85585c3ba6d935753d8240e18baf1 >> >> I bet she got good reasons do to that so I have implemented sti ION >> driver in this mindset. >> > > I agree that having common code would be useful. There are some > generic bindings listed in drivers/staging/android/ion/devicetree.txt > so we could go with linux,ion-heap-dma. > > The changes got merged and there were never mailing list objections > but that's because the devicetree maintainers got busy and never > actually looked at them and Arnd at least still didn't like the > idea of Ion in devicetree. I'd like to wait until after plumbers > next week to decide what to do. > > > >>>> >>> Best, >>> Sumit. >> >> >> >> > > Thanks, > Laura -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog