linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] reset: pistachio: Re-enable driver selection
@ 2021-09-14  9:15 Geert Uytterhoeven
  2021-09-14 14:42 ` Jiaxun Yang
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-09-14  9:15 UTC (permalink / raw)
  To: Philipp Zabel, Thomas Bogendoerfer, Jiaxun Yang, Rahul Bedarkar
  Cc: linux-mips, linux-kernel, Geert Uytterhoeven

After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
longer auto-enabled when building a kernel for Pistachio systems.
Worse, the driver cannot be enabled by the user at all (unless
compile-testing), as the config symbol is invisible.

Fix this partially by making the symbol visible again when compiling for
MIPS, and dropping the useless default.  The user still has to enable
the driver manually when building a kernel for Pistachio systems,
though.

Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/reset/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index be799a5abf8a6edc..b0056ae5d463aedd 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -147,8 +147,8 @@ config RESET_OXNAS
 	bool
 
 config RESET_PISTACHIO
-	bool "Pistachio Reset Driver" if COMPILE_TEST
-	default MACH_PISTACHIO
+	bool "Pistachio Reset Driver"
+	depends on MIPS || COMPILE_TEST
 	help
 	  This enables the reset driver for ImgTec Pistachio SoCs.
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] reset: pistachio: Re-enable driver selection
  2021-09-14  9:15 [PATCH] reset: pistachio: Re-enable driver selection Geert Uytterhoeven
@ 2021-09-14 14:42 ` Jiaxun Yang
  2021-09-15  5:29 ` Rahul Bedarkar
  2021-10-05  9:55 ` Philipp Zabel
  2 siblings, 0 replies; 4+ messages in thread
From: Jiaxun Yang @ 2021-09-14 14:42 UTC (permalink / raw)
  To: Geert Uytterhoeven, Philipp Zabel, Thomas Bogendoerfer, Rahul Bedarkar
  Cc: linux-mips, linux-kernel



在 2021/9/14 10:15, Geert Uytterhoeven 写道:
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default.  The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks!
> ---
>   drivers/reset/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index be799a5abf8a6edc..b0056ae5d463aedd 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -147,8 +147,8 @@ config RESET_OXNAS
>   	bool
>   
>   config RESET_PISTACHIO
> -	bool "Pistachio Reset Driver" if COMPILE_TEST
> -	default MACH_PISTACHIO
> +	bool "Pistachio Reset Driver"
> +	depends on MIPS || COMPILE_TEST
>   	help
>   	  This enables the reset driver for ImgTec Pistachio SoCs.
>   


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] reset: pistachio: Re-enable driver selection
  2021-09-14  9:15 [PATCH] reset: pistachio: Re-enable driver selection Geert Uytterhoeven
  2021-09-14 14:42 ` Jiaxun Yang
@ 2021-09-15  5:29 ` Rahul Bedarkar
  2021-10-05  9:55 ` Philipp Zabel
  2 siblings, 0 replies; 4+ messages in thread
From: Rahul Bedarkar @ 2021-09-15  5:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Philipp Zabel, Thomas Bogendoerfer, Jiaxun Yang, linux-mips,
	linux-kernel

On Tue, Sep 14, 2021 at 2:46 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default.  The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Rahul Bedarkar <rahulbedarkar89@gmail.com>

Thanks,
Rahul

> ---
>  drivers/reset/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index be799a5abf8a6edc..b0056ae5d463aedd 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -147,8 +147,8 @@ config RESET_OXNAS
>         bool
>
>  config RESET_PISTACHIO
> -       bool "Pistachio Reset Driver" if COMPILE_TEST
> -       default MACH_PISTACHIO
> +       bool "Pistachio Reset Driver"
> +       depends on MIPS || COMPILE_TEST
>         help
>           This enables the reset driver for ImgTec Pistachio SoCs.
>
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] reset: pistachio: Re-enable driver selection
  2021-09-14  9:15 [PATCH] reset: pistachio: Re-enable driver selection Geert Uytterhoeven
  2021-09-14 14:42 ` Jiaxun Yang
  2021-09-15  5:29 ` Rahul Bedarkar
@ 2021-10-05  9:55 ` Philipp Zabel
  2 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2021-10-05  9:55 UTC (permalink / raw)
  To: Geert Uytterhoeven, Thomas Bogendoerfer, Jiaxun Yang, Rahul Bedarkar
  Cc: linux-mips, linux-kernel

On Tue, 2021-09-14 at 11:15 +0200, Geert Uytterhoeven wrote:
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
> 
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default.  The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
> 
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you, applied to reset/fixes.

regards
Philipp

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-05  9:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14  9:15 [PATCH] reset: pistachio: Re-enable driver selection Geert Uytterhoeven
2021-09-14 14:42 ` Jiaxun Yang
2021-09-15  5:29 ` Rahul Bedarkar
2021-10-05  9:55 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).