From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E85DC7EE21 for ; Fri, 28 Apr 2023 00:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344560AbjD1As0 (ORCPT ); Thu, 27 Apr 2023 20:48:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjD1AsY (ORCPT ); Thu, 27 Apr 2023 20:48:24 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDC3B2726 for ; Thu, 27 Apr 2023 17:48:23 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-51f3289d306so7023325a12.3 for ; Thu, 27 Apr 2023 17:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682642903; x=1685234903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eYJ9Gq0jRLdthT3KT6+pUq4WeVXKnPD2vRhwxoOwfLM=; b=VAXP1WEMBqFyWeIoabfqwWglRbZ4HdOWER+eOB5RWEer/jpI0svg/f4iWi3c8Cg+Pt by2DSZbfQZ5DKECFJtxEVAvZP00YYuj8SzpYP5frO7HeB/evzIiSXJiYt3uP1AgW6Z/o t4C/VnCsfpRqyoXAvRlPeT9bKt0XI3Ilupw3Lpt0+ypUfNvaXw70RtwacEi3QW5bC93A LD8UutIlcg+pO1Nr1Edae+tN1Cff+2S7B+/D+zIIHdM0zzUfcdgfJeIwzJVmI36PVyU/ HkzP2LpUvgBQhHOexE8LxayxI4ASWaOUCXe+UEfkHJxLKREaLYRvtUXxfqKXe00TIYH9 TjRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682642903; x=1685234903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eYJ9Gq0jRLdthT3KT6+pUq4WeVXKnPD2vRhwxoOwfLM=; b=eR+ChV52a5kgtqQXz5JAFJUQaGdWcb4/cKjeB4gcndNRDFuzE7QNp1VQc9ExgXTqih rPeV7VaT/Sqm+JA/HJWZ3s3OvKD4OzR2u+/xskpHww/rIkA3k1izUvg7XFhyi85AfdU8 3xhlt8gxbXHS2vIY12fWHbT+KtgV1MUNqQDY+U0OOfJBVQoW+b5H/tP6cMve84DgbXGQ o3qKnkbl3pvfO/uefDRIfs3gRuR89RQDlvS5GxV658/7demAa2LUZ45KT/NuWPKhfDGD f9nCavz6DrLJscTJQ0dJS/AwGMr+hx3GTpmx5X4UdGAJ9oBWRo5jqlJcTuK5h3fL9jOU itKA== X-Gm-Message-State: AC+VfDx/yIWcPKkFwpdS1xihNOsNVoW7eTZ8CT8lBkUyopNPCGRJSqxA ec34pLivwErRmZ2X4vTDppkPYEX0xddoAGx/5gHgsQ== X-Google-Smtp-Source: ACHHUZ5+QBvCC7Me3S+WJPhYrRFCfX62qwqHhmjQ8Bf88BjxgWf2Db/JCe7VvvvRDD68Vv7dGvnWJGtUagXHQXv5kDQ= X-Received: by 2002:a17:90a:fc82:b0:247:25d6:b849 with SMTP id ci2-20020a17090afc8200b0024725d6b849mr3639718pjb.8.1682642903149; Thu, 27 Apr 2023 17:48:23 -0700 (PDT) MIME-Version: 1.0 References: <20230418014037.2412394-1-drosen@google.com> <20230418014037.2412394-36-drosen@google.com> In-Reply-To: From: Daniel Rosenberg Date: Thu, 27 Apr 2023 17:48:11 -0700 Message-ID: Subject: Re: [RFC PATCH v3 35/37] tools: Add FUSE, update bpf includes To: Andrii Nakryiko Cc: Miklos Szeredi , bpf@vger.kernel.org, Alexei Starovoitov , Amir Goldstein , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Jonathan Corbet , Joanne Koong , Mykola Lysenko , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 26, 2023 at 9:24=E2=80=AFPM Andrii Nakryiko wrote: > > On Mon, Apr 17, 2023 at 6:42=E2=80=AFPM Daniel Rosenberg wrote: > > > > +/* Return Codes for Fuse BPF struct_op programs */ > > +#define BPF_FUSE_CONTINUE 0 > > +#define BPF_FUSE_USER 1 > > +#define BPF_FUSE_USER_PREFILTER 2 > > +#define BPF_FUSE_POSTFILTER 3 > > +#define BPF_FUSE_USER_POSTFILTER 4 > > nit: can this be an enum instead? It would be more self-documenting, > IMO. At given it's FUSE BPF-specific, why is it not in > uapi/linux/fuse.h? > An enum would be nicer. And I'm sure there are plenty of things that are probably in the wrong place right now. I'll be moving most of the changes in bpf specific areas over to fuse specific areas when struct_ops can handle modules. This particular one can move now though.