From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B83C07E9B for ; Tue, 6 Jul 2021 11:00:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12D40619B6 for ; Tue, 6 Jul 2021 11:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbhGFLDQ (ORCPT ); Tue, 6 Jul 2021 07:03:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231561AbhGFLDP (ORCPT ); Tue, 6 Jul 2021 07:03:15 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08524C061760 for ; Tue, 6 Jul 2021 04:00:37 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id v3so24356361ioq.9 for ; Tue, 06 Jul 2021 04:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D9cJE9ZmLAhI4Z30OwANBpOGqptuN+YARhU6HockOH0=; b=OHgy1t6yQ7FLN3DygkT/BL+g1Fd0Y0bRZKpFs6VjQGau1kDmMGzL7F0PoN0fZTXJd2 Qi9N0mqttZRAXdoPHG83q7gdrpYsOkUxdIvAJSSHYSGWL4DXfbc8zWv9CdDOsFCBwtT+ D23O7XCfv/5/VemHuPMLO7xRZ/ifUDfmjlDdKhcNWYhZ3Ybp1Q3BCBHt85KSa1KysN1P VCJ6i61tTgQHnvs3ll/ziMz3PeOedLUZnwLerwbilVNQKAVBx13i15r3WJ6V0BBIDdUm E0GS4Jm+xxRGuw1x7Jq93k2/zwBGAfrYJz1HGkhFn/hcxSJVliDJet/g+YqaXSia3VbK P5EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D9cJE9ZmLAhI4Z30OwANBpOGqptuN+YARhU6HockOH0=; b=smhpRIzmMMGIFKZwqdlfw7iEwck2mNAQLR1QGWO7Af6XcnnJ9HwSAFQFtaXyudpj42 DtY+X0yKAwrqeHO4+hVCIcktspjhKzj/oAeMe5ll5EqyDrkkmFV+H8OuHnlncak4QQ4O NAs9fA4mtTGDLCIzscpmPhsZ1kBRW96V94bAj/tMekQm7RyzWfylCXh1WqwjFSOM4bp7 W/IX34JPqtyiknKvItf3VRFf7hWcvWghmvnKgKYSWe6wH+RsHtjLTgj+zGJfSyHLwEuC 6ibmi/YcC8gI0g6jN4qaWImPUV2Suy/4EUdji+81IKuOsrVCWKDjCkgTkIL26hMW/4vc DcWA== X-Gm-Message-State: AOAM530WNI2VOfMdFc9489qeul4pEJZVAbVcmzmynqMHM79/EWAHsa7V zDiSvqBcDI1tA/YV8IQKUyVue+pf6foiCHlr1hzzvQ== X-Google-Smtp-Source: ABdhPJwQeTYajARaI85ZZA6cdpsrwFxnkE+PReeU0ZLQgcXDRmZbVRnHS07ukEQ4C29jdKjOddBIiVCJy35vC5fgxEA= X-Received: by 2002:a5d:840c:: with SMTP id i12mr15050087ion.185.1625569236207; Tue, 06 Jul 2021 04:00:36 -0700 (PDT) MIME-Version: 1.0 References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> <1625038079-25815-3-git-send-email-kyrie.wu@mediatek.com> In-Reply-To: <1625038079-25815-3-git-send-email-kyrie.wu@mediatek.com> From: Tzung-Bi Shih Date: Tue, 6 Jul 2021 19:00:25 +0800 Message-ID: Subject: Re: [PATCH v2,2/9] media: mtk-jpegenc: Add MT8195 JPEG venc driver To: "kyrie.wu" Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tomasz Figa , xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 30, 2021 at 3:32 PM kyrie.wu wrote: > Add MT8195 JPEG venc driver's compatible and device private data. > compatible = "mediatek,mt8195-jpgenc": this node would only register > jpgenc device node; > compatible = "mediatek,mt8195-jpgenc0": HW0 node, this node would not > register jpgenc device node, but register irq, init clk and power, > remmap register base and do other resource options; > compatible = "mediatek,mt8195-jpgenc1": HW1 node, just like HW0 node; The commit message is not easy to read. Please rephrase the sentences. What does "venc" stand for? I believe it is a copy-n-paste typo. The commit title "support MT8195 JPEG encoder" looks better to me. > -static const struct mtk_jpeg_variant mtk_jpeg_drvdata = { > +static const struct mtk_jpeg_variant mtk_jpegenc_drvdata = { Why remove mtk_jpeg_drvdata? > - .irq_handler = mtk_jpeg_enc_irq, Why remove the IRQ handler? > @@ -1548,10 +1551,6 @@ static const struct of_device_id mtk_jpeg_match[] = { > .compatible = "mediatek,mt2701-jpgdec", > .data = &mt8173_jpeg_drvdata, > }, > - { > - .compatible = "mediatek,mtk-jpgenc", > - .data = &mtk_jpeg_drvdata, > - }, Why remove "mediatek,mtk-jpgenc"? > +#if defined(CONFIG_OF) > +static const struct of_device_id mtk_jpegenc_hw_ids[] = { > + { > + .compatible = "mediatek,mt8195-jpgenc0", > + }, > + { .compatible = "mediatek,mt8195-jpgenc1", > + }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, mtk_jpegenc_hw_ids); > +#endif Would expect somewhere to reference mtk_jpegenc_hw_ids but failed to find it.