From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A690EC07E9B for ; Tue, 6 Jul 2021 11:01:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 903E861A06 for ; Tue, 6 Jul 2021 11:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231266AbhGFLDk (ORCPT ); Tue, 6 Jul 2021 07:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231817AbhGFLDj (ORCPT ); Tue, 6 Jul 2021 07:03:39 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01139C061764 for ; Tue, 6 Jul 2021 04:01:00 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id u7so22164851ion.3 for ; Tue, 06 Jul 2021 04:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PAM3WxGG2aSByzycYnPlxdEC8iQWk/tth0fjLKjJUmQ=; b=kuy3vDkn1fhRqNRFz8YQPltnu/ZN544qGFslrOfb73mvesqSWnZRLb2FU6oWp6alCe SxmVYx5sLaTlHTOfvsgR988ez7IxSc69Z0G9nxmtyYOCdi2+KxJccGOeEzoc+Aj2G252 Lu9gx6HD6VOMpctXz1IDfUu3BD/kG/RbukpjmSLn++bydCbknoZBSM68z3MMOH5wUXKa fzl4u5B5yf2i1OsFFS8XCeFWfkNpiy4y71M8iU1UwmHm+IryzPu2ZNHiIrDLvB65Devv KmTr0shOoDtArNb19Q4IJKMrjrHNnk+4dqInORDEd0llXi/NP5d0yR2b8Sskvs3TrQNk c6xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PAM3WxGG2aSByzycYnPlxdEC8iQWk/tth0fjLKjJUmQ=; b=GD78TvKiIfEIIRTzQabbKT4TLp/tiWrfMWEKqF+4jMGnsgbekaCRPstnTh+Ao6qX5U g0mFUEvB/HNBA70j9dWwR32YJnbSyEbzUjp6QqIgaUu8HI1WbLfQHceGhXgDNDl3PYOO RDWroV5ASvnGMUvWvB7ga2BaPkNXthwKXSQRBxlVlXzilOi3t77hQKn4nP/syohIulHP x4LPGlMVpY5amgP9w5bzr9tbHpEpmsaokCk3R8KUg4styYFbvPY0KpCqKgPRcpEZW0YT Ro4l3oTar2pkiTDzOAlzY/CeQRGTQ4lAqHsPjYBQ0gUWDuo6o0XcUaULnLa/CQ6gXQaD BtxQ== X-Gm-Message-State: AOAM532eJ2guCLc+KwRJvtgdJN8rcIELFTYn1TLP8uEIkVRuzW7AQ+fj qEmq996jBNDP9HR8+djquKJGVPjLEFMLX4AKwIr+kw== X-Google-Smtp-Source: ABdhPJzwUDQLM/CTRiwWQY8sr2eGBdmmfFG8dIq9UWX1ZvVG78S0nZEd03RB6W99/KoiiJAz3A2AQBBQwiYbb9+BEBo= X-Received: by 2002:a5e:a612:: with SMTP id q18mr15318284ioi.76.1625569259079; Tue, 06 Jul 2021 04:00:59 -0700 (PDT) MIME-Version: 1.0 References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> <1625038079-25815-7-git-send-email-kyrie.wu@mediatek.com> In-Reply-To: <1625038079-25815-7-git-send-email-kyrie.wu@mediatek.com> From: Tzung-Bi Shih Date: Tue, 6 Jul 2021 19:00:48 +0800 Message-ID: Subject: Re: [PATCH v2,6/9] media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces To: "kyrie.wu" Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tomasz Figa , xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 30, 2021 at 3:31 PM kyrie.wu wrote: > +void mtk_jpegenc_timeout_work(struct work_struct *work) No code is using mtk_jpegenc_timeout_work. Have no enough context to review the code. > +{ > + struct mtk_jpeg_dev *jpeg = container_of(work, struct mtk_jpeg_dev, > + job_timeout_work.work); > + struct mtk_jpeg_ctx *ctx; > + struct mtk_jpeg_dev *master_jpeg; > + struct vb2_v4l2_buffer *src_buf, *dst_buf; > + struct mtk_jpeg_src_buf *jpeg_src_buf, *jpeg_dst_buf; > + enum vb2_buffer_state buf_state = VB2_BUF_STATE_ERROR; > + > + src_buf = jpeg->hw_param.src_buffer; > + dst_buf = jpeg->hw_param.dst_buffer; > + ctx = jpeg->hw_param.curr_ctx; Could they be inlined to above where the variables are declared?