From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EB4C4320A for ; Thu, 5 Aug 2021 11:51:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B723A60F42 for ; Thu, 5 Aug 2021 11:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241130AbhHELwC (ORCPT ); Thu, 5 Aug 2021 07:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241116AbhHELwB (ORCPT ); Thu, 5 Aug 2021 07:52:01 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 652A0C061765 for ; Thu, 5 Aug 2021 04:51:46 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id m13so6293370iol.7 for ; Thu, 05 Aug 2021 04:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TsqI2f4PszkolvCq0Vj/MJlhnRVimXlHdN3ztF9TtDc=; b=h9Ihuy67i+BPHbno8ksO+l7rRWsFMJu0B6yiBfPHRxv4EmpMJbRxqk5YJXlz6W7+CO uE3dUWZx6q63v5aX0O09Q1JMpskADy5RGDyKu0RfrPTskZomGnqFq8kR03Wv17C8H9jf N+IXJJsN/bX0rJY4TQlkBqADVsXV/DK/cCjXZwEJGTXFlh3gOL3PIs38B+fbEyzOFZ+c Cs6INT1PEHeTw3r58VBWcelXrfih83TPWsmxr7DYsBdHtP6IXYj3+Javgv7UWyjjAqdt kdrp9QL8apoFudTcrcGvz2k3dGUHLWb20nIxajEAC2b+aZCBG2qEr/us4XG0zUJbVouw yVqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TsqI2f4PszkolvCq0Vj/MJlhnRVimXlHdN3ztF9TtDc=; b=jh7l2FSx3J/UP9hQQ+bWFqKAPznQZ0Jr0g/Ks8q1STzCMyZcSMI2rRllXsnPnHv6DJ 52UAaPNvdZTo87UtRT7bU2PIEfHrHvazyhUkRSviE660vfh1AAdZBcKvfOeA+LmHFF36 ULLf6xqlJBTX3HWFqUOnzKQ+LObl5tNdEffAuZWFkrxFqRrrks2qgarR0KOMP6DVy3fU 5W4x0r33OsBDJyRYq8N5mNktE6jageGzWddTjrthuC2Q1Y3hqSfKJ9omqn5wvQtn7Xee QMvm8OKEeoZOqo3C2ukqbH0Baw18D5cZq8YGkqZWM0tO5pacr2aVNI//F6Em1UqviZNp q1VQ== X-Gm-Message-State: AOAM532b4yF1VdJoJaoW5274ICeKKK2PgPfyiz+j1FRLByIx0W9zFdPu Y3wRH2k7Q+oB9itNEG5/70GPNvi+4e8ikIq1c2nSww== X-Google-Smtp-Source: ABdhPJwN2okbkH6vhEz2oQAP4lCx3J40CVTNusFx6KveRCIE/34YDrRFFEclMt3GEqmVWTQ5dVQczfBztrR21Vfltj4= X-Received: by 2002:a02:cf2e:: with SMTP id s14mr4381393jar.74.1628164305688; Thu, 05 Aug 2021 04:51:45 -0700 (PDT) MIME-Version: 1.0 References: <20210705053258.1614177-1-acourbot@chromium.org> <20210705053258.1614177-12-acourbot@chromium.org> <8929c97f-b105-ee35-d882-1cd218edcfd1@xs4all.nl> In-Reply-To: <8929c97f-b105-ee35-d882-1cd218edcfd1@xs4all.nl> From: Tzung-Bi Shih Date: Thu, 5 Aug 2021 19:51:34 +0800 Message-ID: Subject: Re: [PATCH v6 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding To: Hans Verkuil Cc: Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Dafna Hirschfeld , Yunfei Dong , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 6:52 PM Hans Verkuil wrote: > Several new structs do not have any field documentation, but they do start with /**, > so I get complaints about missing field docs. > > After manually changing this to /*, I still get a few remaining warnings: Will fix in next version. > mtk-vcodec/vdec/vdec_h264_req_if.c:189: warning: Function parameter or member 'h264_slice_params' not described in 'vdec_h264_vsi' > mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'h264_slice_param' not described in 'vdec_h264_slice_inst' > mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'dpb' not described in 'vdec_h264_slice_inst' > > Can you fix this? Will fix in next version. > I also want to take this patch series at the same time: > > https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@mediatek.com/ > > Can you verify that this would not cause any problems with your series? As far as > I can see it is fine, but a second pair of eyeballs wouldn't hurt. Series [1] shouldn't cause any problems with this series. However, series [1] doesn't apply after this series (conflicted with [2]). It needs to rebase and send another version after fixing the typo anyway. [1]: https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@mediatek.com/ [2]: https://patchwork.linuxtv.org/project/linux-media/patch/20210630085247.27554-3-irui.wang@mediatek.com/