From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B61C07E9E for ; Fri, 9 Jul 2021 08:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A76F76124C for ; Fri, 9 Jul 2021 08:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbhGIICt (ORCPT ); Fri, 9 Jul 2021 04:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbhGIICs (ORCPT ); Fri, 9 Jul 2021 04:02:48 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76825C0613DD for ; Fri, 9 Jul 2021 01:00:04 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id h190so11524626iof.12 for ; Fri, 09 Jul 2021 01:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jxeKKZpH8g0VLt4BIsJvm3Kz5ooojk4SyCSTD8gkf4c=; b=gdLMz5E1Qi4ptJm5RLn7ul53NR++fF70gLhRdu6l9pYSqnfiMT2JZivjdfT1BFsNLm a3/LfUMo34qNFd2VMjt0S+EQeSYQjSo24rJPa2TV0qLq2B/ZlufcZXrKUrlM1Hbhw7Qb 2Hwfu5SZgdevJCCG8fdUujt+xoL9jsMmuRTymDZC5b4IdTzKPMYuzsyWjA+zDX/LYYKN 557cCWvjzvqsqLY9Phy9E8W+p8/GiJFOuGsiFCZP2WcpafQ5QGS4xTi7OXoMjeMgvQa1 YaFaxwoZM8KNrMaTDEr9qbEKEsQRqLLZF4Bf3dfXj8PeUteneMuzi/DcpDT+N61MEZdJ SoFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jxeKKZpH8g0VLt4BIsJvm3Kz5ooojk4SyCSTD8gkf4c=; b=kBBneQSdy49TzVv7463O0cgvHsq5s6vJPiVFTsqaEPnK5G/qI/WPCerKwOAenD0+yf 0Sx0VX4iES4PD++b/MNWsELvOqnVCcfwWnHMtBYo3ZYXYUBnQTlGV+6QL99RevGAqa65 WHiZEVrKcPtLlvTW+sVdLI0ywqu9WvnI5tli+YTKUlyow1sCcYULO5OL/tiOSlEPhlv3 cb2VOZw3KiBv36TID2CxmTxKodWQ7M5RQF9nE4UWyNiT4gbKUq8KZX2XYV0LDWLZOZjZ hRb8hAVpi3VdycWBXspenptnpOWgXt8AXymwy6HW7TnKOs8i2HDVhVZwAMISsc1qQrC2 Yzqg== X-Gm-Message-State: AOAM5314/gFJpWQUrBlDsqCyjIyOGnXhni9AIpwJSnexKU/+EHN7/sF/ YV5lBNanAQJ5nCyrlPbw+yqeIRJ9Aczmbu91Aolrfg== X-Google-Smtp-Source: ABdhPJz/iM1VUuaw+LgfAXMYyWsY+UGkYwPTUISY65c4SEG+BA2wd1yXCYcOUPflwPTX6QbLL3qMvB3MPSOQHZigg2s= X-Received: by 2002:a02:c73b:: with SMTP id h27mr24131704jao.126.1625817603524; Fri, 09 Jul 2021 01:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-7-yunfei.dong@mediatek.com> In-Reply-To: <20210707062157.21176-7-yunfei.dong@mediatek.com> From: Tzung-Bi Shih Date: Fri, 9 Jul 2021 15:59:52 +0800 Message-ID: Subject: Re: [PATCH v1, 06/14] media: mtk-vcodec: Add irq interface for core hardware To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > +{ > + if (dev->vdec_pdata->hw_arch == MTK_VDEC_PURE_SINGLE_CORE) > + return 1; > + else if (dev->vdec_pdata->hw_arch == MTK_VDEC_LAT_SINGLE_CORE) > + return 2; > + else > + return 0; > +} Use a switch .. case .. would be easier to read. Would it be better to use some macro or enums for the magic numbers? > @@ -113,8 +114,7 @@ static int mtk_vdec_comp_init_irq(struct mtk_vdec_comp_dev *dev) > } > > ret = devm_request_irq(&pdev->dev, dev->dec_irq, > - mtk_vdec_comp_irq_handler, > - 0, pdev->name, dev); > + mtk_vdec_comp_irq_handler, 0, pdev->name, dev); The change is irrelevant to this patch. > @@ -154,8 +154,10 @@ static int mtk_vdec_comp_probe(struct platform_device *pdev) > dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > > ret = mtk_vdec_comp_init_irq(dev); > - if (ret) > + if (ret) { > + dev_err(&pdev->dev, "Failed to register irq handler.\n"); > goto err; > + } The change shouldn't be in this patch. Instead, another patch that adds the mtk_vdec_comp_init_irq() invocation. > +int mtk_vcodec_wait_for_comp_done_ctx(struct mtk_vcodec_ctx *ctx, Remove the extra space before "*ctx".