From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 539B9C433ED for ; Fri, 21 May 2021 08:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 388F5613AC for ; Fri, 21 May 2021 08:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234635AbhEUIHt (ORCPT ); Fri, 21 May 2021 04:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232744AbhEUIHr (ORCPT ); Fri, 21 May 2021 04:07:47 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C6F9C0613CE for ; Fri, 21 May 2021 01:06:24 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id e10so15882531ilu.11 for ; Fri, 21 May 2021 01:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WAoGYY/IZ06EOl2sgqeBHp4au5PF0E3H2r0EKWA9o4I=; b=RSqrkjnpNv3xOnHZ57xV85Uq945ViwHco45Lb/nK/s/aRNbcF9pCLsb4Y/mHIA3IYC Je32opFAc0+tjj+OFJinHjPHi+Z6Eveu98JACjdv/T0YIZTwGfNRfn7QoGIU6u0xBgi4 kZo5mUmgF8CHehv0XiTKyEvKYc3YNgsBDXDqbt+kjVgG15OM/j8KAkYcu+n2T5Os1kyD Agszq5EsRdHn8bEYnTwe5g9ZABpyl2rZxFP9/FXYrB10YlXSEICIC4Ov2ahNXLmk9rhP 4D6bQthjeF7dN4B8gfI0pGsqR0GP8sWzQM0lVItc/wBdFGwnlSuFFl5ZbnMiyviYnEL3 lwSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WAoGYY/IZ06EOl2sgqeBHp4au5PF0E3H2r0EKWA9o4I=; b=jEQM9uGAh434tp6NBfKuLKt3D7yiwEyC6n037CwRIKWpnW7rvfUMKTsB24pgCm9Ms2 eRS2FPfhns4mBPUwn8dI4SW8PP+cfx1lPlz88SEkm6KNHMLMW/bXN24o8A8wHRWnHFzo JdXxQjgm/JKB8iYZso++11N4820AUqSWCkOSUqC4nMHNAxKMuCct3laRSbIkk2JWNQ9b lOyAMdOg8VhLg9hgfpPYfh0VI1xRXdGLA61FPjHv3mnmZj0w0R5bC2QngN8MWCkJRgVa AsRFNTb2IvoT5T+2F7e06WRz/Te/AVYmznoCNh49u+rNOyTneX4mosKL8xlv+yzRqZYy +BiA== X-Gm-Message-State: AOAM531ufS32Goud87jGFOpaMNiwGYHclrFXjDwMc9RxUHVoDZwnjANz HColigYY+5eO72MpsfuPwebtsBlMmMBPTw0hxK0e2A== X-Google-Smtp-Source: ABdhPJw3h/Rdza5ih9pjbFjbrw/o2STJYHbm+xddgxIMSH3QaWhkLzFTbyk3TsjrO8vCypKIDZQWFwj1Tvz/HMgWS40= X-Received: by 2002:a92:520e:: with SMTP id g14mr10448898ilb.218.1621584383431; Fri, 21 May 2021 01:06:23 -0700 (PDT) MIME-Version: 1.0 References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-4-irui.wang@mediatek.com> In-Reply-To: <20210521070139.20644-4-irui.wang@mediatek.com> From: Tzung-Bi Shih Date: Fri, 21 May 2021 16:06:12 +0800 Message-ID: Subject: Re: [PATCH v4,3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc To: Irui Wang Cc: Alexandre Courbot , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yong Wu , Yunfei Dong , Fritz Koenig , Tzung-Bi Shih , linux-media@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , srv_heupstream@mediatek.com, "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > + >From your previous dt-bindings patch[1], it has 4 banks. > 0~4G; 4G~8G; 8G~12G; 12G~16G. But, the code treats it as a boolean. I.e. 0~4GB if non-existent; otherwise, 4GB~8GB. [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20210521070139.20644-3-irui.wang@mediatek.com/