From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932293AbcBWBic (ORCPT ); Mon, 22 Feb 2016 20:38:32 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36154 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756677AbcBWBib (ORCPT ); Mon, 22 Feb 2016 20:38:31 -0500 MIME-Version: 1.0 In-Reply-To: References: <1456003203-10863-1-git-send-email-diego.viola@gmail.com> <20160220.191659.1399118945067159430.davem@davemloft.net> <20160221124506.00237916@lxorguk.ukuu.org.uk> Date: Mon, 22 Feb 2016 22:38:30 -0300 Message-ID: Subject: Re: [PATCH] jme: remove the jme driver as it is no longer maintained From: Diego Viola To: One Thousand Gnomes , linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, cooldavid@cooldavid.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2016 at 2:17 PM, Diego Viola wrote: > On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes > wrote: >>> I would appreciate some hint from someone who is more experienced with drivers. >> >> Start by testing >> >> - loading the driver as a module >> - using the networking >> - unloading the module (and checking it stays unloaded!) >> >> then suspend/resume >> >> If that works then you have a good starting point because you know a >> sequence of actions that suspends properly. If it fails then it's going >> to be rather more fun because it implies something in the hardware has >> not been properly shut down. >> >> Alan > > Hi Alan, > > Thanks for your email, did you see my bug report? Because I tried all > this already. > > The only workarounds I've found to work is one of these: > > $ rmmod jme # before suspend > > or > > $ ip link set ens34 down > > or > > $ echo 0 > /sys/power/pm_async # disable async power management > > Then resume works fine (I can't reproduce the hang). > > I'm not a C developer nor a kernel developer, I tried looking at the > jme.c driver code but it's not clear what is broken and what needs > fixing, so I would appreciate someone more experienced looking at the > issue and giving me an idea or two. > > Thanks, > Diego Please disregard this patch, I feel like an idiot for sending it. I've found a fix already and sent a patch. Diego