From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932460AbcBWFgR (ORCPT ); Tue, 23 Feb 2016 00:36:17 -0500 Received: from mail-ig0-f170.google.com ([209.85.213.170]:37078 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757267AbcBWFgQ (ORCPT ); Tue, 23 Feb 2016 00:36:16 -0500 MIME-Version: 1.0 In-Reply-To: References: <1456187572-2964-1-git-send-email-diego.viola@gmail.com> <20160222.234234.1952119173455287427.davem@davemloft.net> Date: Tue, 23 Feb 2016 02:36:15 -0300 Message-ID: Subject: Re: [PATCH] net: jme: fix suspend/resume on JMC260 From: Diego Viola To: David Miller Cc: festevam@gmail.com, cooldavid@cooldavid.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richard.weinberger@gmail.com, pavel@ucw.cz, rjw@rjwysocki.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2016 at 2:11 AM, Diego Viola wrote: > On Tue, Feb 23, 2016 at 1:42 AM, David Miller wrote: >> From: Diego Viola >> Date: Mon, 22 Feb 2016 22:58:48 -0300 >> >>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >>>>> Signed-off-by: Diego Viola >>>> >>>> You should write a commit log. >>> >>> I thought about including the link to my bug report: >>> https://bugzilla.kernel.org/show_bug.cgi?id=112351 >>> >>> What else would you suggest I add to the commit message? >> >> The commit message is where you describe the change you are making. >> >> This includes exactly what you are fixing, how you are doing it, and why >> you are doing it that way. >> >> Empty commit log messages are %99.99999 of the time completely >> inappropriate. > > David, > > I understand and appreciate your advice, thanks. > > However, please consider that I'm not a kernel developer, so I don't > understand much or anything about how this driver works internally, > this is why I came here to report about problem in the first place. > > All I can tell you for certain is that this change makes my > suspend/resume work and it doesn't hang anymore while resuming from > suspend. > > I apologize for the empty commit message and for not being able to > explain things deeper, but Pavel Machek is the person who suggested I > make this change in the code, so maybe he can provide some help? > > Diego I will try sending a V2 patch again with a proper commit message, sorry. Diego