* [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9
@ 2018-10-26 1:58 Diego Viola
2018-10-26 11:59 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Diego Viola @ 2018-10-26 1:58 UTC (permalink / raw)
To: hdegoede; +Cc: axboe, tj, linux-kernel, Diego Viola
med_power_with_dipm causes my T450 to freeze with a SAMSUNG
MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
Switching the LPM to max_performance fixes this issue.
Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
drivers/ata/libata-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index a9dd4ea7467d..a7f5202a4815 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
/* These specific Samsung models/firmware-revs do not handle LPM well */
{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
{ "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+ { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
/* devices that don't properly handle queued TRIM commands */
{ "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9
2018-10-26 1:58 [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9 Diego Viola
@ 2018-10-26 11:59 ` Hans de Goede
2018-10-26 13:48 ` Diego Viola
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2018-10-26 11:59 UTC (permalink / raw)
To: Diego Viola; +Cc: axboe, tj, linux-kernel
Hi,
On 26-10-18 03:58, Diego Viola wrote:
> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
>
> Switching the LPM to max_performance fixes this issue.
>
> Signed-off-by: Diego Viola <diego.viola@gmail.com>
Thank you for the patch, have you updated the firmware and
confirmed that this happens with the latest firmware version too ?
If not please send a new version limiting the blacklist to your
firmware version.
Regards,
Hans
> ---
> drivers/ata/libata-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index a9dd4ea7467d..a7f5202a4815 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> /* These specific Samsung models/firmware-revs do not handle LPM well */
> { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> + { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
>
> /* devices that don't properly handle queued TRIM commands */
> { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9
2018-10-26 11:59 ` Hans de Goede
@ 2018-10-26 13:48 ` Diego Viola
2018-10-26 14:33 ` Diego Viola
0 siblings, 1 reply; 4+ messages in thread
From: Diego Viola @ 2018-10-26 13:48 UTC (permalink / raw)
To: hdegoede; +Cc: axboe, tj, linux-kernel
Hi Hans,
On Fri, Oct 26, 2018 at 8:59 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 26-10-18 03:58, Diego Viola wrote:
> > med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> >
> > Switching the LPM to max_performance fixes this issue.
> >
> > Signed-off-by: Diego Viola <diego.viola@gmail.com>
>
> Thank you for the patch, have you updated the firmware and
> confirmed that this happens with the latest firmware version too ?
No, I haven't tired the latest one yet.
The last time I saw, Samsung/Lenovo doesn't make it very easy for
Linux users, and I don't have a Windows installation to perform the
upgrade.
>
> If not please send a new version limiting the blacklist to your
> firmware version.
OK. Sent.
>
> Regards,
>
> Hans
>
>
>
>
> > ---
> > drivers/ata/libata-core.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index a9dd4ea7467d..a7f5202a4815 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> > /* These specific Samsung models/firmware-revs do not handle LPM well */
> > { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> > { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> > + { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
> >
> > /* devices that don't properly handle queued TRIM commands */
> > { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
> >
Regards,
Diego
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9
2018-10-26 13:48 ` Diego Viola
@ 2018-10-26 14:33 ` Diego Viola
0 siblings, 0 replies; 4+ messages in thread
From: Diego Viola @ 2018-10-26 14:33 UTC (permalink / raw)
To: hdegoede; +Cc: axboe, tj, linux-kernel
On Fri, Oct 26, 2018 at 10:48 AM Diego Viola <diego.viola@gmail.com> wrote:
>
> Hi Hans,
>
> On Fri, Oct 26, 2018 at 8:59 AM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > On 26-10-18 03:58, Diego Viola wrote:
> > > med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> > > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> > >
> > > Switching the LPM to max_performance fixes this issue.
> > >
> > > Signed-off-by: Diego Viola <diego.viola@gmail.com>
> >
> > Thank you for the patch, have you updated the firmware and
> > confirmed that this happens with the latest firmware version too ?
>
> No, I haven't tired the latest one yet.
s/tired/tried/
>
> The last time I saw, Samsung/Lenovo doesn't make it very easy for
> Linux users, and I don't have a Windows installation to perform the
> upgrade.
>
> >
> > If not please send a new version limiting the blacklist to your
> > firmware version.
>
> OK. Sent.
>
> >
> > Regards,
> >
> > Hans
> >
> >
> >
> >
> > > ---
> > > drivers/ata/libata-core.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > > index a9dd4ea7467d..a7f5202a4815 100644
> > > --- a/drivers/ata/libata-core.c
> > > +++ b/drivers/ata/libata-core.c
> > > @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> > > /* These specific Samsung models/firmware-revs do not handle LPM well */
> > > { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> > > { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> > > + { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
> > >
> > > /* devices that don't properly handle queued TRIM commands */
> > > { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
> > >
>
> Regards,
> Diego
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-26 14:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 1:58 [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9 Diego Viola
2018-10-26 11:59 ` Hans de Goede
2018-10-26 13:48 ` Diego Viola
2018-10-26 14:33 ` Diego Viola
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).